Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance log to include milliseconds #686

Closed
offerm opened this issue Nov 18, 2018 · 5 comments · Fixed by #775
Closed

Enhance log to include milliseconds #686

offerm opened this issue Nov 18, 2018 · 5 comments · Fixed by #775
Assignees
@rsercano
Labels
has PR issues with an open PR logging Log messages and output
Milestone
1.0.0-alpha.7

Comments

@offerm
Copy link
Contributor

offerm commented Nov 18, 2018

Enhance log output to inlcude milliseconds in each printing.

Today we only should the time up to the seconds.
@offerm offerm added this to the 1.0.0-alpha.5 milestone Nov 18, 2018
@sangaman sangaman added the logging Log messages and output label Nov 18, 2018
@kilrau kilrau modified the milestones: 1.0.0-alpha.5, 1.0.0-alpha.6 Nov 20, 2018
@kilrau kilrau assigned ghost and unassigned sangaman Dec 6, 2018
@rsercano
Copy link
Collaborator

This issue seems pretty easy, so I can take over if you're okay with it ? For the miliseconds if we want to print miliseconds then we need to specify format instead of printing current javascript runtime format. I can take this format in config file and provide a default one if not provided.

@rsercano rsercano assigned rsercano and unassigned ghost Dec 26, 2018
@sangaman
Copy link
Collaborator

Oh yes it had just slipped my mind, go for it if you have time @rsercano. I agree it would be a nice feature.

rsercano pushed a commit to rsercano/xud that referenced this issue Dec 26, 2018
added date formatting for logger via config param ExchangeUnion#686
a011264
@rsercano rsercano mentioned this issue Dec 26, 2018
Merged
@ghost ghost added the in progress label Dec 26, 2018
@offerm
Copy link
Contributor Author

offerm commented Dec 26, 2018 via email

@rsercano
Copy link
Collaborator

Now we pick date format from configuration, so everyone can change as how they wish, but I can set the default format as LND if you wish @offerm ?

@kilrau kilrau modified the milestones: 1.0.0-alpha.6, 1.0.0-alpha.8 Jan 2, 2019
@kilrau
Copy link
Contributor

kilrau commented Jan 2, 2019

default format as LND sounds good! @rsercano

rsercano pushed a commit to rsercano/xud that referenced this issue Jan 3, 2019
ExchangeUnion#686 set LND as default date format for logger
1e92007
@moshababo moshababo added the has PR issues with an open PR label Jan 4, 2019
moshababo pushed a commit that referenced this issue Jan 6, 2019
@rsercano @moshababo
feat: add configurable logger date formatting
ee66a6c 
* added date formatting for logger via config param #686

* typo

* typo

* added trailing comma

* #686 set LND as default date format for logger

* na
@ghost ghost removed the in progress label Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsercano rsercano

Labels
has PR issues with an open PR logging Log messages and output
Projects
None yet
Milestone
1.0.0-alpha.7
Development

Successfully merging a pull request may close this issue.

Added date formatting for logger via config param #686 rsercano/xud
5 participants
@sangaman @rsercano @offerm @moshababo @kilrau