Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add currencyReceived and currencySent to SwapResult rpc message #670

Closed
sangaman opened this issue Nov 13, 2018 · 2 comments
Closed

Add currencyReceived and currencySent to SwapResult rpc message #670

sangaman opened this issue Nov 13, 2018 · 2 comments
Assignees
@sangaman
Labels
grpc gRPC API swaps
Milestone
1.0.0-alpha.5

Comments

@sangaman
Copy link
Collaborator

Currently the SwapResult grpc message includes amountReceived and amountSent but no indication of what currency was received and which was sent. Previously it would have been possible to determine this based on pairId and whether the quantity was negative (sell) or positive (buy), but since we changed how that worked to make quantity always positive, it's not possible without looking up the order. I suggest adding currencyReceived and currencySent to make it clear exactly which currencies changed hands.
@sangaman sangaman added grpc gRPC API swaps labels Nov 13, 2018
@sangaman sangaman self-assigned this Nov 13, 2018
@kilrau
Copy link
Contributor

kilrau commented Nov 13, 2018

This looks relatively small - this or next milestone?

@sangaman
Copy link
Collaborator Author

Yeah it's small, but I think lets leave it for next milestone because I want to implement it after #669 is merged.

@sangaman sangaman added this to the 1.0.0-alpha.5 milestone Nov 13, 2018
sangaman added a commit that referenced this issue Nov 20, 2018
@sangaman
feat(rpc): add currencies to swap result
b8db0e4 
This adds `currency_received` and `currency_sent` to the gRPC
`SwapResult` message. Without these fields, it is not possible to tell
from the swap result alone which currency was send or received by either
party.

Closes #670.
@sangaman sangaman mentioned this issue Nov 20, 2018
Merged
@ghost ghost added the in progress label Nov 20, 2018
sangaman added a commit that referenced this issue Nov 20, 2018
@sangaman
feat(rpc): add currencies to swap result
86dfed4 
This adds `currency_received` and `currency_sent` to the gRPC
`SwapResult` message. Without these fields, it is not possible to tell
from the swap result alone which currency was send or received by either
party.

Closes #670.
@ghost ghost removed the in progress label Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangaman sangaman

Labels
grpc gRPC API swaps
Projects
None yet
Milestone
1.0.0-alpha.5
Development

No branches or pull requests
2 participants
@sangaman @kilrau