Refactor swap clients to be generic, remove hardcoded btclnd/ltclnd #554
Assignees
Labels
code quality
Improving code structure, organization, and clarity
has PR
issues with an open PR
lightning
Lightning network & lnd integration
swaps
Milestone
Comments
sangaman
added
code quality
|
Can I take this? |
sangaman
changed the title
|
I had some ideas for how to approach this, if you don't mind let me have a chance at it after alpha.1 is tagged, but if I'm not able to get it to soon then you can definitely take it. |
sangaman
added a commit
that referenced
this issue
Feb 13, 2019
This replaces all hardcoded references to the `lndbtc` and `lndltc` clients with generic collections of lnd clients identified by their currency/ticker symbol such as "BTC" as in `lndClients.BTC`. This will allow adding lnd clients for newly supported currencies without in the future without requiring changes to `xud`. It also reduces the amount of boilerplate code that's required in the codebase. Closes #554. BREAKING CHANGE: Changes p2p packet structures for packets that communicate the node state. BREAKING CHANGE: Changes the way lnd config options are passed in via command line arguments.
ghost
added
the
sangaman
added a commit
that referenced
this issue
Feb 28, 2019
This replaces all hardcoded references to the `lndbtc` and `lndltc` clients with generic collections of lnd clients identified by their currency/ticker symbol such as "BTC" as in `lndClients.BTC`. This will allow adding lnd clients for newly supported currencies without in the future without requiring changes to `xud`. It also reduces the amount of boilerplate code that's required in the codebase. Closes #554. BREAKING CHANGE: Changes p2p packet structures for packets that communicate the node state. BREAKING CHANGE: Changes the way lnd config options are passed in via command line arguments.
sangaman
added a commit
that referenced
this issue
Feb 28, 2019
This replaces all hardcoded references to the `lndbtc` and `lndltc` clients with generic collections of lnd clients identified by their currency/ticker symbol such as "BTC" as in `lndClients.BTC`. This will allow adding lnd clients for newly supported currencies without in the future without requiring changes to `xud`. It also reduces the amount of boilerplate code that's required in the codebase. Closes #554. BREAKING CHANGE: Changes p2p packet structures for packets that communicate the node state. BREAKING CHANGE: Changes the way lnd config options are passed in via command line arguments.
sangaman
added a commit
that referenced
this issue
Mar 1, 2019
This replaces all hardcoded references to the `lndbtc` and `lndltc` clients with generic collections of lnd clients identified by their currency/ticker symbol such as "BTC" as in `lndClients.BTC`. This will allow adding lnd clients for newly supported currencies without in the future without requiring changes to `xud`. It also reduces the amount of boilerplate code that's required in the codebase. Closes #554. BREAKING CHANGE: Changes p2p packet structures for packets that communicate the node state. BREAKING CHANGE: Changes the way lnd config options are passed in via command line arguments.
sangaman
added a commit
that referenced
this issue
Mar 9, 2019
This replaces all hardcoded references to the `lndbtc` and `lndltc` clients with generic collections of lnd clients identified by their currency/ticker symbol such as "BTC" as in `lndClients.BTC`. This will allow adding lnd clients for newly supported currencies without in the future without requiring changes to `xud`. It also reduces the amount of boilerplate code that's required in the codebase. Closes #554. BREAKING CHANGE: Changes p2p packet structures for packets that communicate the node state. BREAKING CHANGE: Changes the way lnd config options are passed in via command line arguments.
sangaman
added a commit
that referenced
this issue
Mar 9, 2019
This replaces all hardcoded references to the `lndbtc` and `lndltc` clients with generic collections of lnd clients identified by their currency/ticker symbol such as "BTC" as in `lndClients.BTC`. This will allow adding lnd clients for newly supported currencies without in the future without requiring changes to `xud`. It also reduces the amount of boilerplate code that's required in the codebase. Closes #554. BREAKING CHANGE: Changes p2p packet structures for packets that communicate the node state. BREAKING CHANGE: Changes the way lnd config options are passed in via command line arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is to track refactoring code to make lnd swap clients generic and configurable. Currently we hardcode
btclndandltclndas the only supported networks, but longer term we'd need to support more and we don't want code changes for each one.The text was updated successfully, but these errors were encountered: