Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeorder responce returns partial removal message instead of full #2020

Closed
raladev opened this issue Dec 4, 2020 · 2 comments · Fixed by #2022
Closed

removeorder responce returns partial removal message instead of full #2020

raladev opened this issue Dec 4, 2020 · 2 comments · Fixed by #2022
Assignees
@sangaman @kilrau
Labels
bug Something isn't working grpc gRPC API order book P1 top priority

Comments

@raladev
Copy link
Contributor

raladev commented Dec 4, 2020

Steps:

  1. place order
  2. remove it

Actual result:
message says that order was removed partially and full amount of order displayed as remaining
Screenshot from 2020-12-04 18-20-59

Expected result:
Order fully removed

Note:
Partial removing works fine (correct message and value)
@raladev raladev added bug Something isn't working P1 top priority labels Dec 4, 2020
@kilrau
Copy link
Contributor

kilrau commented Dec 4, 2020

Is it "just" the message that is wrong or the matching itself?

@raladev
Copy link
Contributor Author

raladev commented Dec 4, 2020

Is it "just" the message that is wrong or the matching itself?

just a message

sangaman added a commit that referenced this issue Dec 4, 2020
@sangaman
fix(rpc): 0 remaining quantity on full remove
78a053b 
This fixes a bug where fully removing an order via `RemoveOrder` would
return the entire quantity of the order as the remaining quantity
instead of zero.

Fixes #2020
@sangaman sangaman self-assigned this Dec 4, 2020
@sangaman sangaman mentioned this issue Dec 4, 2020
Merged
sangaman added a commit that referenced this issue Dec 4, 2020
@sangaman
fix(rpc): 0 remaining quantity on full remove
14f50cc 
This fixes a bug where fully removing an order via `RemoveOrder` would
return the entire quantity of the order as the remaining quantity
instead of zero.

Fixes #2020
sangaman added a commit that referenced this issue Dec 5, 2020
@sangaman
fix(rpc): 0 remaining quantity on full remove
dcd8f90 
This fixes a bug where fully removing an order via `RemoveOrder` would
return the entire quantity of the order as the remaining quantity
instead of zero.

Fixes #2020
raladev pushed a commit that referenced this issue Dec 5, 2020
@sangaman
fix(rpc): 0 remaining quantity on full remove (#2022)
de7fd48 
* feat(cli): cleaner removeorder output

* fix(rpc): 0 remaining quantity on full remove

This fixes a bug where fully removing an order via `RemoveOrder` would
return the entire quantity of the order as the remaining quantity
instead of zero.

Fixes #2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangaman sangaman

@kilrau kilrau

Labels
bug Something isn't working grpc gRPC API order book P1 top priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rpc): 0 remaining quantity on full remove ExchangeUnion/xud
3 participants
@sangaman @kilrau @raladev