Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional --sat_per_byte arg to openchannel #1829

Closed
kilrau opened this issue Aug 22, 2020 · 2 comments · Fixed by #1832
Closed

Add optional --sat_per_byte arg to openchannel #1829

kilrau opened this issue Aug 22, 2020 · 2 comments · Fixed by #1832
Assignees
@rsercano
Labels
good first issue Good for newcomers P2 mid priority

Comments

@kilrau
Copy link
Contributor

kilrau commented Aug 22, 2020

for btc/ltc only, others should throw an invalid arg error
@kilrau kilrau added the P2 mid priority label Aug 22, 2020
@kilrau kilrau added the good first issue Good for newcomers label Aug 22, 2020
@rsercano
Copy link
Collaborator

May I take this?

@kilrau kilrau changed the title Add optional --sat_per_vbyte arg to openchannel Add optional --sat_per_byte arg to openchannel Aug 24, 2020
@kilrau
Copy link
Contributor Author

kilrau commented Aug 24, 2020

You got it. This should be as simple as mapping to lnd's sat_per_byte (https://api.lightning.community/#openchannel).

rsercano pushed a commit that referenced this issue Aug 24, 2020
sat_per_byte added to openchannel #1829
8945352
@rsercano rsercano mentioned this issue Aug 24, 2020
Merged
sangaman pushed a commit that referenced this issue Sep 22, 2020
@sangaman
feat: sat_per_byte custom fee for openchannel
596992b 
Resolves #1829.
raladev pushed a commit that referenced this issue Sep 22, 2020
@rsercano
feat: sat_per_byte custom fee for openchannel (#1832)
b56ad98 
Resolves #1829.

Co-authored-by: sercan.ozdemir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsercano rsercano

Labels
good first issue Good for newcomers P2 mid priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added optional --sat_per_byte arg to openchannel for lnd ExchangeUnion/xud
3 participants
@sangaman @rsercano @kilrau