Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make debug.testing default (& rm the option) add new production.strict option #1757

Closed
kilrau opened this issue Jul 24, 2020 · 0 comments · Fixed by #1759
Closed

Make debug.testing default (& rm the option) add new production.strict option #1757

kilrau opened this issue Jul 24, 2020 · 0 comments · Fixed by #1759
Assignees
Labels
P1 top priority question/tbd Further information or discussion needed

Comments

@kilrau
Copy link
Contributor

kilrau commented Jul 24, 2020

As discussed on discord, I'd like to turn things around: instead of being very strict and gradually adding more things to debug.testing because they hinder real-world usage, I'd open it up to the best degree possible and slowly start getting stricter once things mature.

I propose to remove the current debug.testing option and make the behavior behind this flag the the default behavior.

Some of the features this is disabling will become useful though in future, that's why I propose to add a new production.strict option that enables the following:

  • peers mutually banning each other because of severe L2 payment errors like "NO ROUTE FOUND".
  • disabling currencies for a certain peer because of swap failure
  • removing all orders of a peer because of swap failure
@kilrau kilrau added question/tbd Further information or discussion needed P1 top priority labels Jul 24, 2020
@kilrau kilrau assigned ghost and sangaman Jul 24, 2020
sangaman added a commit that referenced this issue Jul 27, 2020
This replaces the `debug.testing` option with a `strict` option and
makes the default behavior non-strict, equivalent to running xud with
`debug.testing` before.

Closes #1757.
@ghost ghost closed this as completed in #1759 Jul 28, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 top priority question/tbd Further information or discussion needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants