Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap Recovery: start immediately (not after 30s only) #1598

Closed
kilrau opened this issue Jun 2, 2020 · 0 comments · Fixed by #1600
Closed

Swap Recovery: start immediately (not after 30s only) #1598

kilrau opened this issue Jun 2, 2020 · 0 comments · Fixed by #1600
Assignees
Labels
enhancement New feature or request P2 mid priority swaps

Comments

@kilrau
Copy link
Contributor

kilrau commented Jun 2, 2020

Follow-up of #1549:
since swap recovery is now used as a default way to handle looking up states of outgoing payments, we want to do the first try immediately after a swap enters swap recovery.

@kilrau kilrau added enhancement New feature or request P2 mid priority labels Jun 2, 2020
sangaman added a commit that referenced this issue Jun 3, 2020
This commit makes it so that any swap deals that fail as maker while
sending payment will have the payment checked immediately upon being
added to set of swaps tracked by the `SwapRecovery` module. This is
instead of waiting for the 30 second timer to periodically retry tracked
swaps

It also refactors the code around checking and rechecking swaps that
may have a pending payment involved, and enhances logging output.

Closes #1598.
@kilrau kilrau added the swaps label Jun 3, 2020
sangaman added a commit that referenced this issue Jun 3, 2020
This commit makes it so that any swap deals that fail as maker while
sending payment will have the payment checked immediately upon being
added to set of swaps tracked by the `SwapRecovery` module. This is
instead of waiting for the 30 second timer to periodically retry tracked
swaps

It also refactors the code around checking and rechecking swaps that
may have a pending payment involved, and enhances logging output.

Closes #1598.
@ghost ghost closed this as completed in #1600 Jun 4, 2020
ghost pushed a commit that referenced this issue Jun 4, 2020
This commit makes it so that any swap deals that fail as maker while
sending payment will have the payment checked immediately upon being
added to set of swaps tracked by the `SwapRecovery` module. This is
instead of waiting for the 30 second timer to periodically retry tracked
swaps

It also refactors the code around checking and rechecking swaps that
may have a pending payment involved, and enhances logging output.

Closes #1598.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 mid priority swaps
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants