Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same currency pair can be added #1559

Closed
raladev opened this issue May 14, 2020 · 1 comment · Fixed by #1941
Closed

Same currency pair can be added #1559

raladev opened this issue May 14, 2020 · 1 comment · Fixed by #1941
Assignees
@rsercano
Labels
bug Something isn't working P3 low priority

Comments

@raladev
Copy link
Contributor

raladev commented May 14, 2020

Steps to reproduce

  1. Add Pair BTC/BTC
  2. Place order to BTC/BTC order book and fill it

Expected behaviour

No opportunity to add /<same_symbol> because:

  1. its useless action
  2. for now eth/eth swap leads to SwapTimeOut and 500 Connext Error

Actual behaviour

Pair Added, Swap performed
Note: These Swaps work only for lndbtc and lndltc and dont work for Connext pairs (leads to SwapTimeOut and 500 Connext Error).
@raladev raladev added bug Something isn't working question/tbd Further information or discussion needed labels May 14, 2020
@raladev raladev added the P3 low priority label May 14, 2020
@kilrau kilrau changed the title <symbol>/<same_symbol> pair can be added same currency pair can be added May 23, 2020
@kilrau kilrau removed their assignment May 23, 2020
@kilrau kilrau changed the title same currency pair can be added Same currency pair can be added May 23, 2020
@kilrau kilrau removed the question/tbd Further information or discussion needed label Oct 19, 2020
@kilrau
Copy link
Contributor

kilrau commented Oct 19, 2020 •
edited
Loading

I think what we want to do here is: if base_asset == quote_asset in addpair, throw Base asset and quote asset have to be different. error. Should be a quick win @rsercano

rsercano added a commit that referenced this issue Oct 20, 2020
@rsercano
fix: addpair should prevent adding same base and quote assets (#1559)
e066621
@rsercano rsercano mentioned this issue Oct 20, 2020
Merged
rsercano added a commit that referenced this issue Oct 21, 2020
@rsercano
fix: addpair should prevent adding same base and quote assets (#1559)
69f502f
sangaman added a commit that referenced this issue Oct 21, 2020
@sangaman
Merge pull request #1941 from ExchangeUnion/fix/addpair-same-assets
c839774 
fix: addpair should prevent adding same base and quote assets (#1559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsercano rsercano

Labels
bug Something isn't working P3 low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: addpair should prevent adding same base and quote assets (#1559) ExchangeUnion/xud
3 participants
@rsercano @kilrau @raladev