Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xud processing order updates for pairs I do not have #1530

Closed
kilrau opened this issue May 7, 2020 · 5 comments · Fixed by #1890
Closed

xud processing order updates for pairs I do not have #1530

kilrau opened this issue May 7, 2020 · 5 comments · Fixed by #1890
Assignees
@rsercano
Labels
bug Something isn't working order book p2p Peer to peer networking P2 mid priority

Comments

@kilrau
Copy link
Contributor

kilrau commented May 7, 2020 •
edited
Loading

How it is

I do not have the pair btc/xuc set up on my xud (I do have xuc/btc set up though), xud is receiving order invalidations for such peer and actually tries to remove the order; which fails of course.

07/05/2020 11:24:11.754 [P2P] verbose: received order invalidation from 02778bcd8f1f578bbb2f3ff345ecccdb5865e4a08a0cfd98145da08ca3470c3e74 (ReadyAbsurd): {"id":"409fb610-9055-11ea-b76d-13690b06b3b3","pairId":"BTC/XUC","quantity":10000000}
07/05/2020 11:24:11.755 [ORDERBOOK] error: failed to remove order (409fb610-9055-11ea-b76d-13690b06b3b3) of peer 02778bcd8f1f578bbb2f3ff345ecccdb5865e4a08a0cfd98145da08ca3470c3e74 (ReadyAbsurd)

How it should be

  • xud knows about a peers pairs, don't send updates for pairs the peer doesn't have
  • if an update gets send anyways, xud on the receiving side ignores such an update, adding a log entry in trace level, but not default log level (debug)
@kilrau kilrau added bug Something isn't working P3 low priority labels May 7, 2020
@kilrau kilrau assigned sangaman and unassigned sangaman May 7, 2020
@kilrau kilrau changed the title xud processing order updates for pairs I don't have xud processing order updates for pairs I do not have Jul 8, 2020
@kilrau kilrau added P2 mid priority order book p2p Peer to peer networking and removed P3 low priority labels Aug 13, 2020
@kilrau
Copy link
Contributor Author

kilrau commented Aug 13, 2020

As @erkarl pointed out, this could be abused to add new pairs and flood the network (and everyone's logs) with these failure messages.

@rsercano
Copy link
Collaborator

rsercano commented Sep 3, 2020

May I take this please? Want to check

@kilrau kilrau assigned rsercano and unassigned sangaman Sep 3, 2020
@kilrau
Copy link
Contributor Author

kilrau commented Sep 3, 2020

you got it

@rsercano rsercano mentioned this issue Sep 3, 2020
Closed
@rsercano
Copy link
Collaborator

rsercano commented Sep 10, 2020 •
edited
Loading

Will we create another issue for GetOrders packet? @sangaman @raladev

@raladev
Copy link
Contributor

raladev commented Sep 10, 2020

Will we create another issue for GetOrders packet? @sangaman @raladev

#1884
This PR should fix it

rsercano added a commit that referenced this issue Sep 11, 2020
@rsercano
fix: order invalidation only be sent to peers with active pair (#1530)
4bebd3f 
Signed-off-by: rsercano <[email protected]>
@rsercano rsercano mentioned this issue Sep 11, 2020
Merged
raladev pushed a commit that referenced this issue Sep 11, 2020
@rsercano
fix: order invalidation only be sent to peers with active pair (#1530) (
0dc85bd 
#1890)

Signed-off-by: rsercano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsercano rsercano

Labels
bug Something isn't working order book p2p Peer to peer networking P2 mid priority
Projects
None yet
Milestone
No milestone
4 participants
@sangaman @rsercano @kilrau @raladev