Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed seedutil call prints the seed in the logs #1254

Closed
ghost opened this issue Sep 27, 2019 · 1 comment · Fixed by #1257
Closed

Failed seedutil call prints the seed in the logs #1254

ghost opened this issue Sep 27, 2019 · 1 comment · Fixed by #1257
Labels
P1 top priority

Comments

@ghost
Copy link

ghost commented Sep 27, 2019

When the call to seedutil fails we're printing the seed in the logs.

https://github.com/ExchangeUnion/xud/blob/master/lib/swaps/SwapClientManager.ts#L158

xud_1        | 27/09/2019 09:22:24.879 [RAIDEN] warn: could not create keystore: Error: Command failed: ./seedutil/seedutil -pass= -path=/root/.ethereum abstract destroy cupboard medal gallery horse mandate add have animal half shield series first other develop canyon rain skill segment oil top fox clock
xud_1        | /bin/sh: ./seedutil/seedutil: not found

I'm wondering if we completely want to remove that error message or still display it when the log level is set to something like trace?
@ghost ghost self-assigned this Sep 27, 2019
@ghost ghost mentioned this issue Sep 27, 2019
Merged
@kilrau
Copy link
Contributor

kilrau commented Sep 27, 2019 •
edited
Loading

I'm wondering if we completely want to remove that error message or still display it when the log level is set to something like trace?

I would completely remove it. A seed should never end up in the logs, no matter the log level and I don't see how we can do that in fail-safe way.

But let's give @sangaman a chance to comment

@kilrau kilrau added the P1 top priority label Sep 27, 2019
ghost pushed a commit that referenced this issue Sep 30, 2019
fix(seedutil): avoid logging seed in logs
6fdc36b 
In this commit we're reducing the verbosity of a failed `seedutil` call
to not include the exact error message since it will also print the seed
phrase to the logs.

Fixes #1254
@ghost ghost mentioned this issue Sep 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 top priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(seedutil): avoid logging seed in logs ExchangeUnion/xud
1 participant
@kilrau