-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement of listtrades
#1232
Comments
Took #1243 (comment) and changed
condensed this into (imho better readable):
Not necessary imo:
|
I thought to leave routing fees out of the buy/sell amount to keep them clean and comparable among peers. That's why Also I thought about renaming |
I like this naming, but before we can display it we need to preserve it. I'm tracking it in #1565. |
This replaces the partially implemented `ListTrades` call with the more comprehensive and descriptive `TradeHistory`. This displays key info about every trade we have made. Closes #1232.
This replaces the partially implemented `ListTrades` call with the more comprehensive and descriptive `TradeHistory`. This displays key info about every trade we have made. Closes #1232.
This replaces the partially implemented `ListTrades` call with the more comprehensive and descriptive `TradeHistory`. This displays key info about every trade we have made. Closes #1232.
This replaces the partially implemented `ListTrades` call with the more comprehensive and descriptive `TradeHistory`. This displays key info about every trade we have made. Closes #1232.
This replaces the partially implemented `ListTrades` call with the more comprehensive and descriptive `TradeHistory`. This displays key info about every trade we have made. Closes #1232.
This replaces the partially implemented `ListTrades` call with the more comprehensive and descriptive `TradeHistory`. This displays key info about every trade we have made. Closes #1232.
Completed at
: Timestamp (formatted, json can be unix)Order ID
: UUID of the original order, can be the OrderID of multiple trades in the event of partial fills. abbrev. in formatted output, full in json output.Trade ID
: rhash , abbreviated in formatted output, full in json outputPrice per ETH
:0.02 BTC
Buy (Received)
:50 ETH
Sell (Sent)
:1 BTC
Add. Network Fees
:0.0000004 BTC
Role
: Taker/MakerPeer
: AliasAnd probably we can close #625, I see a huge overlap and would want to avoid confusion by having two very similar calls listing trade/swap history.
The text was updated successfully, but these errors were encountered: