refactor(rpc): rename GetOrders to ListOrders (#709)

Closes #691.

lib/cli/commands/getorders.ts → lib/cli/commands/listorders.ts

@@ -1,6 +1,6 @@
 import { Arguments } from 'yargs';
 import { callback, loadXudClient } from '../command';
-import { GetOrdersRequest, GetOrdersResponse, Order, OrderSide } from '../../proto/xudrpc_pb';
+import { ListOrdersRequest, ListOrdersResponse, Order, OrderSide } from '../../proto/xudrpc_pb';
 import Table, { HorizontalTable } from 'cli-table3';
 import colors from 'colors/safe';
 
@@ -38,7 +38,7 @@ const addSide = (orderSide: Order.AsObject[]): string[] => {
   }
 };
 
-export const formatOrders = (orders: GetOrdersResponse.AsObject) => {
+export const formatOrders = (orders: ListOrdersResponse.AsObject) => {
   const formattedOrders: FormattedTradingPairOrders[] = [];
   orders.ordersMap.forEach((tradingPair) => {
     const buy = sortOrders(tradingPair[1].buyOrdersList, true);
@@ -84,13 +84,13 @@ const displayOrdersTable = (tradingPair: FormattedTradingPairOrders) => {
   console.log(table.toString());
 };
 
-const displayTables = (orders: GetOrdersResponse.AsObject) => {
+const displayTables = (orders: ListOrdersResponse.AsObject) => {
   formatOrders(orders).forEach(displayOrdersTable);
 };
 
-export const command = 'getorders [pair_id]';
+export const command = 'listorders [pair_id]';
 
-export const describe = 'get orders from the order book';
+export const describe = 'list orders from the order book';
 
 export const builder = {
   pair_id: {
@@ -99,9 +99,9 @@ export const builder = {
 };
 
 export const handler = (argv: Arguments) => {
-  const request = new GetOrdersRequest();
+  const request = new ListOrdersRequest();
   const pairId = argv.pair_id ? argv.pair_id.toUpperCase() : undefined;
   request.setPairId(pairId);
   request.setIncludeOwnOrders(true);
-  loadXudClient(argv).getOrders(request, callback(argv, displayTables));
+  loadXudClient(argv).listOrders(request, callback(argv, displayTables));
 };

lib/grpc/GrpcServer.ts

@@ -30,7 +30,7 @@ class GrpcServer {
       executeSwap: grpcService.executeSwap,
       getInfo: grpcService.getInfo,
       getNodeInfo: grpcService.getNodeInfo,
-      getOrders: grpcService.getOrders,
+      listOrders: grpcService.listOrders,
       listCurrencies: grpcService.listCurrencies,
       listPairs: grpcService.listPairs,
       listPeers: grpcService.listPeers,

lib/grpc/GrpcService.ts

@@ -355,24 +355,24 @@ class GrpcService {
   }
 
   /**
-   * See [[Service.getOrders]]
+   * See [[Service.listOrders]]
    */
-  public getOrders: grpc.handleUnaryCall<xudrpc.GetOrdersRequest, xudrpc.GetOrdersResponse> = (call, callback) => {
+  public listOrders: grpc.handleUnaryCall<xudrpc.ListOrdersRequest, xudrpc.ListOrdersResponse> = (call, callback) => {
     try {
-      const getOrdersResponse = this.service.getOrders(call.request.toObject());
-      const response = new xudrpc.GetOrdersResponse();
+      const listOrdersResponse = this.service.listOrders(call.request.toObject());
+      const response = new xudrpc.ListOrdersResponse();
 
-      const getOrdersList = <T extends Order>(orders: T[]) => {
+      const listOrdersList = <T extends Order>(orders: T[]) => {
         const ordersList: xudrpc.Order[] = [];
         orders.forEach(order => ordersList.push(createOrder(<Order>order)));
         return ordersList;
       };
 
       const ordersMap = response.getOrdersMap();
-      getOrdersResponse.forEach((orderArrays, pairId) => {
+      listOrdersResponse.forEach((orderArrays, pairId) => {
         const orders = new xudrpc.Orders();
-        orders.setBuyOrdersList(getOrdersList(orderArrays.buy));
-        orders.setSellOrdersList(getOrdersList(orderArrays.sell));
+        orders.setBuyOrdersList(listOrdersList(orderArrays.buy));
+        orders.setSellOrdersList(listOrdersList(orderArrays.sell));
 
         ordersMap.set(pairId, orders);
       });