Skip to content

Commit

Permalink
refactor(orderbook): set localId to global id if unset
Browse files Browse the repository at this point in the history
This commit modifies `Orderbook.stampOwnOrder` to set `localId` to
global `id` in case `localId` is not provided.
  • Loading branch information
Karl Ranna committed Nov 13, 2018
1 parent 8b1199f commit 8540623
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions lib/orderbook/OrderBook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -521,14 +521,15 @@ class OrderBook extends EventEmitter {
}

public stampOwnOrder = (order: OwnLimitOrder): OwnOrder => {
// verify localId isn't duplicated. generate one if it's blank
const id = uuidv1();
// verify localId isn't duplicated. use global id if blank
if (order.localId === '') {
order.localId = uuidv1();
order.localId = id;
} else if (this.localIdMap.has(order.localId)) {
throw errors.DUPLICATE_ORDER(order.localId);
}

return { ...order, initialQuantity: order.quantity, id: uuidv1(), createdAt: ms() };
return { ...order, id, initialQuantity: order.quantity, createdAt: ms() };
}

private createOutgoingOrder = (order: orders.OwnOrder): orders.OutgoingOrder => {
Expand Down

0 comments on commit 8540623

Please sign in to comment.