chore: update simnet images #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Apr 9, 2020
tests/integration/test_simnet.py
Outdated
| exit_code, output = utils.exec_run("cat /var/log/launcher.log") | ||
| print(output.decode()) | ||
|
|
||
| # exit_code, output = find("xud").exec_run("xucli --rpcport=18886 getinfo") |
There was a problem hiding this comment.
This is the part I've not planned well about which is revealing some useful debug information when the test fails. Anyway I well refine this part later.
reliveyy
force-pushed
the
chore/update-simnet
branch
4 times, most recently
from
f832f51 to
dfe232a
Compare
|
A more readable error state would be better (?)
|
@peartobear Sorry this PR is still pending becuase the our GCP simnet is still not ready. |
reliveyy
force-pushed
the
chore/update-simnet
branch
from
dfe232a to
648e3a6
Compare
|
This is currently not fully working due to #419 (comment) |
|
Last commit sets xud grpc listening address to 127.0.0.1, which magically turned the xud grpc listen on |
This status will show when "xucli getinfo" got an error like:
/app/node_modules/yargs/yargs.js:1175
else throw err
^
Error: ENOENT: no such file or directory, open '/root/.xud/tls.cert'
at Object.openSync (fs.js:457:3)
at Object.readFileSync (fs.js:359:35)
at Object.exports.loadXudClient (/app/dist/cli/command.js:23:31)
at Object.exports.handler (/app/dist/cli/commands/getinfo.js:69:15)
at Object.runCommand (/app/node_modules/yargs/lib/command.js:237:40)
at Object.parseArgs [as _parseArgs] (/app/node_modules/yargs/yargs.js:1090:30)
at Object.get [as argv] (/app/node_modules/yargs/yargs.js:1024:21)
at Object.<anonymous> (/app/bin/xucli:40:3)
at Module._compile (internal/modules/cjs/loader.js:1158:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10) {
errno: -2,
syscall: 'open',
code: 'ENOENT',
path: '/root/.xud/tls.cert'
}
reliveyy
force-pushed
the
chore/update-simnet
branch
from
3dcb67d to
f6d6903
Compare
|
This commit moving all We could now try to bring things back, but I rather suggest we remove all simnet specific logic and have the regular create/write down mnemonic, set passwords, set backup location flow for simnet too, just like on testnet/mainnet. The only difference is, that channels come automatically and money is "for free". |
|
it was decided to create separate issue for task in priveous comment, since it was easier to return autocreation and we did not want to block the merge by this comment. #425 |
ghost
merged commit
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will update simnet environment to latest xud-simnet master
How to test?
Run xud script with
-b chore/update-simnetthen select simnet you should have latest xud-simnet experience (auto channel openning is included in this PR).Closes #326
Reopen previous PR #346