Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for 4-byte ASNs in x.y Notation #2

Closed
thomas-mangin opened this issue Aug 27, 2013 · 2 comments
Closed

Add Support for 4-byte ASNs in x.y Notation #2

thomas-mangin opened this issue Aug 27, 2013 · 2 comments
Assignees
Labels

Comments

@thomas-mangin
Copy link
Member

From [email protected] on July 14, 2011 17:31:38

If you attempt to include a 4-byte ASN in the x.y notation, exabgp exits with a traceback.

To see this, include an AS Path that includes an ASN in the x.y notation, such as:

as-path 1.123;

There are two items here:
a) Feature: It doesn't support x.y notation for ASNs.
b) Bug: It doesn't gracefully handle non-numeric ASNs.

The attached patch should add support for ASNs in the x.y notation and also cause exabgp to raise a syntax error when it encounters a non-numeric ASN. I tested it locally and it behaved as expected.

I am using exabgp 1.3.3 on FreeBSD 8.2 with Python 2.6.6.

Attachment: exabgp.patch

Original issue: http://code.google.com/p/exabgp/issues/detail?id=2

@ghost ghost assigned thomas-mangin Aug 27, 2013
@thomas-mangin
Copy link
Member Author

From thomas.mangin on July 14, 2011 13:13:55

This feature is now implemented in mercurial as requested.
Thank you for the patch, I have implemented a slightly different version which should address both issues.

Status: Fixed
Owner: thomas.mangin

@thomas-mangin
Copy link
Member Author

From thomas.mangin on November 16, 2012 02:05:48

Status: Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant