Skip to content

fix: Custom Scp127 clipsizes causing desyncs#599

Merged
louis1706 merged 2 commits intoExMod-Team:devfrom
Someone-193:CustomScp127AmmoFix
Aug 1, 2025
Merged

fix: Custom Scp127 clipsizes causing desyncs#599
louis1706 merged 2 commits intoExMod-Team:devfrom
Someone-193:CustomScp127AmmoFix

Conversation

@Someone-193
Copy link
Copy Markdown

Description

Describe the changes
I fixed a small nullability issue then changed the methods directly using base game SetAmmo methods to use Exileds methods (which check the AmmoType to be valid)

What is the current behavior? (You can also link to an open issue here)
Scp 127's AmmoType is 255 for exiled cuz NW never added an official ammo for 127. Because of this, when a Custom Weapon 127 reloads and calls OnInternalReloaded, it would do ev.Player.Inventory.ServerSetAmmo(args); and cause the client to desync because the use AmmoType was None

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:
Why didn't Ttrouble just use ev.Player.SetAmmo 😭

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@louis1706 louis1706 merged commit 597cef6 into ExMod-Team:dev Aug 1, 2025
6 checks passed
@Someone-193 Someone-193 deleted the CustomScp127AmmoFix branch December 20, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants