Skip to content

fix: CustomRoles GotRoleHint.Show config#583

Merged
louis1706 merged 1 commit intoExMod-Team:devfrom
Rat-s-Kingdom:vrdev
Jul 5, 2025
Merged

fix: CustomRoles GotRoleHint.Show config#583
louis1706 merged 1 commit intoExMod-Team:devfrom
Rat-s-Kingdom:vrdev

Conversation

@officialvirtualrain
Copy link
Copy Markdown

Description

Describe the changes
added a check if GotRoleHint is actually enabled

What is the current behavior? (You can also link to an open issue here)
hint shows regardless of whether it is enabled/disabled

What is the new behavior? (if this is a feature change)
hint shows only when its enabled in config

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@louis1706 louis1706 merged commit 79d5f41 into ExMod-Team:dev Jul 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants