feat(fix): related things

[IRacle1]

Description

Describe the changes

• fixed PumpBarrelMagazine::IsCocked
• fixed NormalMagazine::Ammo setter (dont set when magazine is not inserted)
  
• fixed microhid bug by creating in Item.Create
• fixed rooms generation
• fixed logic for AmmoDrain == 0

What is the current behavior? (You can also link to an open issue here)
😔

What is the new behavior? (if this is a feature change)
🥹

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no🥴

Other information:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentations

Submission checklist

• I have checked the project can be compiled
• I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

• I have checked no IL patching errors in the console

Other

• Still requires more testing

[LumiFae]

what the hell is a feat(fix)

[IRacle1]

what the hell is a feat(fix)

feat and fix🤨

[LumiFae]

what the hell is a feat(fix)

feat and fix🤨

yeah that's not how conventional commits is... if it has a feature (and fixes) then it's just feat, if it has just fixes, fix. also the brackets stuff is for the scope, so it will be smth like feat(API) for api features, feat(Events) for event features 😭

[IRacle1]

what the hell is a feat(fix)

feat and fix🤨

yeah that's not how conventional commits is... if it has a feature (and fixes) then it's just feat, if it has just fixes, fix. also the brackets stuff is for the scope, so it will be smth like feat(API) for api features, feat(Events) for event features 😭

I don't really see the point of thinking about the name of a pr, which includes a lot of independent things that are hard to summarize😔

[LumiFae]

you'll get used to it the more you do it, but yes i think the way conventional commits is used here is wrong, but can also be useful, the reason it's called conventional commits is because it's supposed to be used for commit titles not PR titles but last time I raised that everyone went wild so I'm not doing that again. i can help with a title when this pr is no longer a draft, just ping me. unless it's mostly finished now then I can figure out smth now

[VALERA771]

@IRacle1 is it ready for merging?

[IRacle1]

Yep