Skip to content

fix: fix announcing ntf/chaos entrance events#314

Merged
BoltonDev merged 2 commits intoExMod-Team:scpsl14from
BoltonDev:fix/announcing-event
Dec 17, 2024
Merged

fix: fix announcing ntf/chaos entrance events#314
BoltonDev merged 2 commits intoExMod-Team:scpsl14from
BoltonDev:fix/announcing-event

Conversation

@BoltonDev
Copy link
Copy Markdown
Member

Description

Describe the changes

  • Add TargetMethods to each transpiler of these events since we can't use multiple harmonypatch attribute at the same place.
  • Fix ev.IsAllowed for the both events.
  • Add a new transpiler to prevent cassie from playing if the string builder is empty.
  • Other changes.

What is the current behavior? (You can also link to an open issue here)

  • Announcing events aren't called for mini waves.
  • ev.IsAllowed doesn't work.
  • Some properties setter make the server crashes.
  • ..

What is the new behavior? (if this is a feature change)

  • Fix all above.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@BoltonDev BoltonDev changed the title fix: announcing ntf/chaos entrance events fix: fix announcing ntf/chaos entrance events Dec 15, 2024
@BoltonDev BoltonDev changed the title fix: fix announcing ntf/chaos entrance events fix: fix announcing ntf/chaos entrance eventsa Dec 15, 2024
@BoltonDev BoltonDev changed the title fix: fix announcing ntf/chaos entrance eventsa fix: fix announcing ntf/chaos entrance events Dec 15, 2024
@BoltonDev BoltonDev requested a review from louis1706 December 16, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants