Skip to content

fix: fix respawning and selecting team events that make server crash#313

Merged
BoltonDev merged 3 commits intoExMod-Team:scpsl14from
BoltonDev:fix/respawn-event
Dec 17, 2024
Merged

fix: fix respawning and selecting team events that make server crash#313
BoltonDev merged 3 commits intoExMod-Team:scpsl14from
BoltonDev:fix/respawn-event

Conversation

@BoltonDev
Copy link
Copy Markdown
Member

Description

Describe the changes

  • Add Base property to TimedWave & WaveTimer
  • Change default property of IsAllowed of selecting team event to true
  • Call Base property in each transpiler of the respecting fixed event

What is the current behavior? (You can also link to an open issue here)
When you don't change anything, players aren't able to respawn. If you set IsAllowed to true of selecting, the server crashes.

What is the new behavior? (if this is a feature change)
Fixed all of these problems.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@@ -21,40 +21,43 @@ namespace Exiled.API.Features.Waves
/// </summary>
public class TimedWave
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add the IWrapper ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IWrapper still requires MonoBehaviour since it hasn't been merged yet, it's in the SSSS pr

@BoltonDev BoltonDev requested a review from louis1706 December 16, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants