fix: fix respawning and selecting team events that make server crash#313
Merged
BoltonDev merged 3 commits intoExMod-Team:scpsl14from Dec 17, 2024
Merged
fix: fix respawning and selecting team events that make server crash#313BoltonDev merged 3 commits intoExMod-Team:scpsl14from
BoltonDev merged 3 commits intoExMod-Team:scpsl14from
Conversation
VALERA771
approved these changes
Dec 14, 2024
louis1706
reviewed
Dec 14, 2024
| @@ -21,40 +21,43 @@ namespace Exiled.API.Features.Waves | |||
| /// </summary> | |||
| public class TimedWave | |||
Member
Author
There was a problem hiding this comment.
IWrapper still requires MonoBehaviour since it hasn't been merged yet, it's in the SSSS pr
ebb6f63 to
fcebf43
Compare
louis1706
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Baseproperty toTimedWave&WaveTimerIsAllowedof selecting team event totrueBaseproperty in each transpiler of the respecting fixed eventWhat is the current behavior? (You can also link to an open issue here)
When you don't change anything, players aren't able to respawn. If you set IsAllowed to true of selecting, the server crashes.
What is the new behavior? (if this is a feature change)
Fixed all of these problems.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other