`[Exiled::Events]` `[Exiled::API]` New event + new property by VALERA771 · Pull Request #31 · ExMod-Team/EXILED

VALERA771 · 2024-08-03T11:24:50Z

Description

Describe the changes
Adding new event - Escaped.
Adding new property for player - PreviousRole (tested).

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentations

Submission checklist

I have checked the project can be compiled
I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

I have checked no IL patching errors in the console

Other

Still requires more testing

EXILED/Exiled.Events/Patches/Events/Player/EscapingAndEscaped.cs

louis1706

Add EscapedEventArgs::SpawnableTeamType
Add EscapedEventArgs::NumberOfTicket
Add EscapedEventArgs::RoleType
Add EscapedEventArgs::EscapeTime

Also only for EscapeScenario don't take it from previous event but from the Ldloc_1 in case plugin or NWAPI change it's way to make this event to not interfere

VALERA771 · 2024-08-06T21:18:15Z

Add EscapedEventArgs::SpawnableTeamType

Add EscapedEventArgs::NumberOfTicket

Add EscapedEventArgs::RoleType

Add EscapedEventArgs::EscapeTime

Also only for EscapeScenario don't take it from previous event but from the Ldloc_1 in case plugin or NWAPI change it's way to make this event to not interfere

Technically, we can get RoleTypeId and SpawnableTeamType from Escape scenario
(Wtf I can edit messages from other users?!)

louis1706 · 2024-08-07T06:56:00Z

Add EscapedEventArgs::SpawnableTeamType

Add EscapedEventArgs::NumberOfTicket

Add EscapedEventArgs::RoleType

Add EscapedEventArgs::EscapeTime

Also only for EscapeScenario don't take it from previous event but from the Ldloc_1 in case plugin or NWAPI change it's way to make this event to not interfere

Technically, we can get RoleTypeId and SpawnableTeamType from Escape scenario
(Wtf I can edit messages from other users?!)

Yeah that why i ask to add them :)

(Yes your devboy)

EXILED/Exiled.Events/EventArgs/Player/EscapedEventArgs.cs

# Conflicts: # EXILED/Exiled.Events/Patches/Events/Player/EscapingAndEscaped.cs

louis1706

If transpiller work it's fine

EXILED/Exiled.API/Features/Player.cs

…xMod-Team#31)" This reverts commit 043d9a9.

* `[Exiled::Events]` `[Exiled::API]` New event + new property (#31) * new ev + previous role * suggestions * uwu * suj * fix * uwu --------- Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com> * [EXILED::Events] BeingObserved event stolen (#91) * Scp173 Observing, Stolen from https://github.com/ExMod-Team/EXILED/pull/72/files * Remove old comment * Fix Error Co-Authored-By: SrLicht <cerberus.tk.sl@gmail.com> * NW Documentation * moving forward * YES * Fix * Update * Index Update * Change Order * OrderBy * Revert "Fix Error" This reverts commit d53d84d. * Revert "[EXILED::Events] BeingObserved event stolen (#91)" This reverts commit cc7c183. * Revert "`[Exiled::Events]` `[Exiled::API]` New event + new property (#31)" This reverts commit 043d9a9. * remove using * NW_Documentation * SCPSLRessources NW doc * Change * try to fix labeller try to fix labeler * Update DamageHandler Doc * Revert partially This reverts commit 03122a3. --------- Co-authored-by: VALERA771 <72030575+VALERA771@users.noreply.github.com> Co-authored-by: X <24619207+Undid-Iridium@users.noreply.github.com> Co-authored-by: SrLicht <cerberus.tk.sl@gmail.com>

new ev + previous role

3f404c9

github-actions bot assigned VALERA771 Aug 3, 2024

github-actions bot added Events Transpiler API labels Aug 3, 2024

IRacle1 reviewed Aug 4, 2024

View reviewed changes

EXILED/Exiled.Events/Patches/Events/Player/EscapingAndEscaped.cs Outdated Show resolved Hide resolved

louis1706 requested changes Aug 6, 2024

View reviewed changes

obvEve approved these changes Aug 9, 2024

View reviewed changes

suggestions

c40c52f

obvEve requested changes Aug 12, 2024

View reviewed changes

EXILED/Exiled.Events/EventArgs/Player/EscapedEventArgs.cs Outdated Show resolved Hide resolved

uwu

cac9a15

VALERA771 requested review from louis1706 and obvEve August 12, 2024 13:59

louis1706 requested changes Aug 12, 2024

View reviewed changes

EXILED/Exiled.Events/EventArgs/Player/EscapedEventArgs.cs Outdated Show resolved Hide resolved

VALERA771 added 3 commits August 12, 2024 17:39

suj

bddd7d3

Merge remote-tracking branch 'upstream/dev' into escaped-event

e2f58c5

# Conflicts: # EXILED/Exiled.Events/Patches/Events/Player/EscapingAndEscaped.cs

fix

2147c94

VALERA771 requested a review from louis1706 August 12, 2024 15:19

louis1706 approved these changes Aug 12, 2024

View reviewed changes

obvEve approved these changes Aug 13, 2024

View reviewed changes

louis1706 approved these changes Aug 14, 2024

View reviewed changes

Jesus-QC requested changes Sep 23, 2024

View reviewed changes

EXILED/Exiled.API/Features/Player.cs Outdated Show resolved Hide resolved

uwu

8732744

VALERA771 requested a review from Jesus-QC October 11, 2024 22:10

louis1706 approved these changes Oct 19, 2024

View reviewed changes

louis1706 approved these changes Nov 5, 2024

View reviewed changes

louis1706 added 2 commits November 9, 2024 09:19

Merge branch 'dev' into escaped-event

fc059b9

Merge branch 'dev' into escaped-event

1f2f7e2

VALERA771 merged commit 043d9a9 into ExMod-Team:dev Nov 9, 2024

louis1706 added a commit to louis1706/EXILED that referenced this pull request Nov 17, 2024

Revert "[Exiled::Events] [Exiled::API] New event + new property (E…

d8fa348

…xMod-Team#31)" This reverts commit 043d9a9.

VALERA771 deleted the escaped-event branch December 20, 2024 17:49

dependabot bot mentioned this pull request Aug 5, 2025

Bump ExMod.Exiled and 9 others Bill3621/BillsPlugin-EXILED#5

Open

dependabot bot mentioned this pull request Aug 26, 2025

Bump ExMod.Exiled from 8.13.1 to 9.8.1 Bill3621/BillsPlugin-EXILED#9

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`[Exiled::Events]` `[Exiled::API]` New event + new property#31

`[Exiled::Events]` `[Exiled::API]` New event + new property#31
VALERA771 merged 9 commits intoExMod-Team:devfrom
VALERA771:escaped-event

VALERA771 commented Aug 3, 2024 •

edited

Loading

Uh oh!

Uh oh!

louis1706 left a comment •

edited by VALERA771

Loading

Uh oh!

VALERA771 commented Aug 6, 2024

Uh oh!

louis1706 commented Aug 7, 2024

Uh oh!

Uh oh!

Uh oh!

louis1706 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

VALERA771 commented Aug 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Submission checklist

Patches (if there are any changes related to Harmony patches)

Other

Uh oh!

Uh oh!

louis1706 left a comment • edited by VALERA771 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VALERA771 commented Aug 6, 2024

Uh oh!

louis1706 commented Aug 7, 2024

Uh oh!

Uh oh!

Uh oh!

louis1706 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VALERA771 commented Aug 3, 2024 •

edited

Loading

louis1706 left a comment •

edited by VALERA771

Loading