Skip to content

Fix EndingRound event#304

Merged
BoltonDev merged 1 commit intoExMod-Team:scpsl14from
BoltonDev:fix-roundend
Dec 6, 2024
Merged

Fix EndingRound event#304
BoltonDev merged 1 commit intoExMod-Team:scpsl14from
BoltonDev:fix-roundend

Conversation

@BoltonDev
Copy link
Copy Markdown
Member

Description

Describe the changes

  • Replace base game logic with LeadingTeam leadingTeam = ev.LeadingTeam
    • This fix getter & setter of ev.LeadingTeam
  • Remove IsRoundEnded (IsAllowed do the same)

What is the current behavior? (You can also link to an open issue here)

  • ev.LeadingTeam always return FacilityForces (represents 0)
  • ev.LeadingTeam setter doesn't work
  • unneeded property in the event

What is the new behavior? (if this is a feature change)

  • ev.LeadingTeam return the correct LeadingTeam
  • set ev.LeadingTeam change the team that win the round
  • IsRoundEnded is now IsAllowed

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] EndingRoundEventArgs.LeadingTeam property setter does not work.

2 participants