Skip to content

A lot of breaking changes#303

Merged
VALERA771 merged 11 commits intoExMod-Team:scpsl14from
ITeMbI4:DoingBacklog
Dec 9, 2024
Merged

A lot of breaking changes#303
VALERA771 merged 11 commits intoExMod-Team:scpsl14from
ITeMbI4:DoingBacklog

Conversation

@ITeMbI4
Copy link
Copy Markdown

@ITeMbI4 ITeMbI4 commented Dec 5, 2024

Description

Describe the changes
Doing a lot of to do

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes, a lot

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@ITeMbI4 ITeMbI4 marked this pull request as ready for review December 5, 2024 19:54
Copy link
Copy Markdown

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love breaking everything

/// <summary>
/// Gets a value indicating whether the player's <see cref="RoleTypeId"/> is any NTF rank.
/// Gets a value indicating whether the player's <see cref="RoleTypeId"/> is any NTF rank and not a Facility Guard.
/// Equivalent to checking the player's <see cref="Team"/>.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this line

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is wrong there?

@VALERA771 VALERA771 requested a review from louis1706 December 9, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants