Merged
Conversation
Misaka-ZeroTwo
previously approved these changes
Dec 3, 2024
louis1706
reviewed
Dec 3, 2024
louis1706
left a comment
louis1706
left a comment
There was a problem hiding this comment.
for YamlDotNet i prefer to use the one from base game
Misaka-ZeroTwo
dismissed
their stale review
Version is different from base game
Author
|
There is no package with version 11.1.3.0, so I'll revert yaml changes |
Collaborator
Actually there is |
Author
|
Weird naming =) |
still better to use the on from SCP:SL file directly so we don't need to update it |
IRacle1
approved these changes
Dec 3, 2024
Comment on lines
-34
to
+36
| <Reference Include="YamlDotNet" HintPath="$(EXILED_REFERENCES)\YamlDotNet.dll" Private="false" /> | ||
| <Reference Include="System.Net.Http" /> | ||
| <Reference Include="Mono.Posix" HintPath="$(EXILED_REFERENCES)\Mono.Posix.dll" Private="false" /> | ||
| <Reference Include="YamlDotNet" HintPath="$(EXILED_REFERENCES)\YamlDotNet.dll" Private="false" /> |
obvEve
approved these changes
Dec 3, 2024
louis1706
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Update project credits
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other