New Shot patch

[Banalny-Banan]

Description

Describe the changes
Added new Shot patch

What is the current behavior? (You can also link to an open issue here)
Current Shot patch is using Physics.Raycast in its constructor and is missing crucial CanHurt field that is widely used in plugins

What is the new behavior? (if this is a feature change)
Mentioned issues are fixed

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes, it removes MaxDistance field from ShotEventArgs. This field is just as relevant as including raycast mask in the event (not at all)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentations

Submission checklist

• I have checked the project can be compiled
• I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

• I have checked no IL patching errors in the console

Other

• Still requires more testing

[BoltonDev]

MaxDistance isn't a constant value, the value is different if the firearm used is a disruptor

[Banalny-Banan]

MaxDistance isn't a constant value, the value is different if the firearm used is a disruptor

I know, but this information is still not a part of the Shot. It's a parameter of the firearm just like fire rate or max ammo. If plugins want to access the parameters of the Firearm they can do so directly.

[BoltonDev]

Also i don't think CanHurt should be a part of the ShotEvent as we can already do that in the HurtingEvent by checking the DamageHandler. ShotEvent represents the action of firing a firearm

[Banalny-Banan]

CanHurt is useful when you are making a weapon with a custom way of dealing damage and want to cancel the default. It is possible in Hurting, but why not have it here if we can? Also its backward compatibility since this field was there for more than a year.

[Banalny-Banan]

@BoltonDev Ready for review

[BoltonDev]

It looks good, just could confirm that you have tested your changes and everything is working as expected?

[Banalny-Banan]

@BoltonDev Yes, its tested and working correctly