feat: timed waves#286
Merged
VALERA771 merged 9 commits intoExMod-Team:scpsl14from Dec 3, 2024
LumiFae:scpsl14
Merged
Conversation
Author
|
Just expanding on this PR, most of the stuff implemented here I have tested myself to see if it works just using the direct methods and it does. |
obvEve
approved these changes
Dec 3, 2024
Author
|
merge time!!! |
|
Why github still displays you as a first-time contributor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add easier and more readable to understand methods when controlling timed waves.
What is the current behavior? (You can also link to an open issue here)
There is no documentation behind these and sometimes the variables are a bit confusing on what they do.
What is the new behavior? (if this is a feature change)
There is now documentation, better use of the C# spec and better variable names.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes, it does make a breaking change but no one is required to change their code to use this.
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other