Skip to content

feat: timed waves#286

Merged
VALERA771 merged 9 commits intoExMod-Team:scpsl14from
LumiFae:scpsl14
Dec 3, 2024
Merged

feat: timed waves#286
VALERA771 merged 9 commits intoExMod-Team:scpsl14from
LumiFae:scpsl14

Conversation

@LumiFae
Copy link
Copy Markdown

@LumiFae LumiFae commented Dec 1, 2024

Description

Add easier and more readable to understand methods when controlling timed waves.

What is the current behavior? (You can also link to an open issue here)
There is no documentation behind these and sometimes the variables are a bit confusing on what they do.

What is the new behavior? (if this is a feature change)
There is now documentation, better use of the C# spec and better variable names.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes, it does make a breaking change but no one is required to change their code to use this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@LumiFae
Copy link
Copy Markdown
Author

LumiFae commented Dec 2, 2024

Just expanding on this PR, most of the stuff implemented here I have tested myself to see if it works just using the direct methods and it does.

Copy link
Copy Markdown

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NW surprises me more and more

Copy link
Copy Markdown
Member

@obvEve obvEve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes in DMs

@LumiFae
Copy link
Copy Markdown
Author

LumiFae commented Dec 3, 2024

merge time!!!

@VALERA771
Copy link
Copy Markdown

Why github still displays you as a first-time contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants