Fix ChangingRoleAndSpawned#282
Merged
VALERA771 merged 2 commits intoExMod-Team:scpsl14from Dec 1, 2024
Merged
Conversation
IRacle1
approved these changes
Dec 1, 2024
Member
IRacle1
left a comment
IRacle1
left a comment
There was a problem hiding this comment.
id prefer add checks in patch, but anyway
VALERA771
approved these changes
Dec 1, 2024
kijetesantakalu912345
added a commit
to kijetesantakalu912345/SLCryptoAuth
that referenced
this pull request
Nov 2, 2025
the unrelated bug in question is exiled erroring before setting the inventory when spawning. im not sure why or how SLCryptoAuth is triggering this exiled bug but it's occurring anyway so it looks like i'll have to separately fork exiled and bring bug fixes from future versions to old versions. the fix is literally just this PR, but it was made way after exiled 8.12.2 ExMod-Team/EXILED#282
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
The eventargs for ChangingRole could be null sometimes (if player not verified), which breaks ChangeInventory method.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other