Skip to content

Individual ff#274

Merged
louis1706 merged 1 commit intoExMod-Team:scpsl14from
Misaka-SL-Project:individualFF
Nov 30, 2024
Merged

Individual ff#274
louis1706 merged 1 commit intoExMod-Team:scpsl14from
Misaka-SL-Project:individualFF

Conversation

@Misaka-ZeroTwo
Copy link
Copy Markdown
Collaborator

@Misaka-ZeroTwo Misaka-ZeroTwo commented Nov 30, 2024

Description

Describe the changes
image

Moved the patch (from red to green) for custom FF to make it not trigger for certain damage handlers. Those damage handlers shouldn't cause self-damage.

What is the current behavior? (You can also link to an open issue here)
Jailbird can damage the owner cuz we skip NW check.

What is the new behavior? (if this is a feature change)
Jailbird will not damage the owner

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Misaka-ZeroTwo
Copy link
Copy Markdown
Collaborator Author

I am unsure why it wasn't an issue previously tbh.

@IRacle1
Copy link
Copy Markdown
Member

IRacle1 commented Nov 30, 2024

I am unsure why it wasn't an issue previously tbh.

maybe it was, ive encountered a few times the strange logic of blowing yourself up on grenades with ff disabled(before 14.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants