Fix Flashbang & HE

EXILED/Exiled.API/Extensions/RoleExtensions.cs

@@ -13,6 +13,7 @@ namespace Exiled.API.Extensions
 
     using Enums;
     using Exiled.API.Features.Spawn;
+    using Footprinting;
     using InventorySystem;
     using InventorySystem.Configs;
     using PlayerRoles;
@@ -27,6 +28,22 @@ namespace Exiled.API.Extensions
     /// </summary>
     public static class RoleExtensions
     {
+        /// <summary>
+        /// Compares LifeIdentifier.
+        /// </summary>
+        /// <param name="footprint">The footprint to compare.</param>
+        /// <param name="other">The other footprint.</param>
+        /// <returns>If LifeIdentifier is the same (same role).</returns>
+        public static bool CompareLife(this Footprint footprint, Footprint other) => footprint.LifeIdentifier == other.LifeIdentifier;
+
+        /// <summary>
+        /// Compares LifeIdentifier.
+        /// </summary>
+        /// <param name="footprint">The footprint to compare.</param>
+        /// <param name="other">The hub to compare to.</param>
+        /// <returns>If LifeIdentifier is the same (same role).</returns>
+        public static bool CompareLife(this Footprint footprint, ReferenceHub other) => footprint.LifeIdentifier == other.roleManager.CurrentRole.UniqueLifeIdentifier;
+
         /// <summary>
         /// Gets a <see cref="RoleTypeId">role's</see> <see cref="Color"/>.
         /// </summary>

EXILED/Exiled.API/Features/Roles/Role.cs

@@ -114,6 +114,11 @@ protected Role(PlayerRoleBase baseRole)
         /// </summary>
         public bool IsValid => Owner != null && Owner.IsConnected && Base == Owner.RoleManager.CurrentRole;
 
+        /// <summary>
+        /// Gets the life identifier for the role.
+        /// </summary>
+        public int LifeIdentifier => Base.UniqueLifeIdentifier;
+
         /// <summary>
         /// Gets a random spawn position of this role.
         /// </summary>

EXILED/Exiled.Events/Patches/Events/Map/ExplodingFlashGrenade.cs

@@ -12,6 +12,7 @@ namespace Exiled.Events.Patches.Events.Map
 
     using API.Features;
     using API.Features.Pools;
+    using Exiled.API.Extensions;
     using Exiled.Events.EventArgs.Map;
     using Exiled.Events.Patches.Generic;
     using Footprinting;
@@ -63,14 +64,13 @@ private static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstructi
         private static void ProcessEvent(FlashbangGrenade instance, float distance)
         {
             List<Player> targetToAffect = ListPool<Player>.Pool.Get();
-            foreach (ReferenceHub referenceHub in ReferenceHub.AllHubs)
+            foreach (Player player in Player.List)
             {
-                Player player = Player.Get(referenceHub);
-                if ((instance.transform.position - referenceHub.transform.position).sqrMagnitude >= distance)
+                if ((instance.transform.position - player.Position).sqrMagnitude >= distance)
                     continue;
-                if (!ExiledEvents.Instance.Config.CanFlashbangsAffectThrower && instance.PreviousOwner.LifeIdentifier != new Footprint(referenceHub).LifeIdentifier)
+                if (!ExiledEvents.Instance.Config.CanFlashbangsAffectThrower && instance.PreviousOwner.CompareLife(player.ReferenceHub))
                     continue;
-                if (!IndividualFriendlyFire.CheckFriendlyFirePlayer(instance.PreviousOwner, player.ReferenceHub) && instance.PreviousOwner.LifeIdentifier != new Footprint(referenceHub).LifeIdentifier)
+                if (!IndividualFriendlyFire.CheckFriendlyFirePlayer(instance.PreviousOwner, player.ReferenceHub) && !instance.PreviousOwner.CompareLife(player.ReferenceHub))
                     continue;
                 if (Physics.Linecast(instance.transform.position, player.CameraTransform.position, instance._blindingMask))
                     continue;

EXILED/Exiled.Events/Patches/Generic/IndividualFriendlyFire.cs

@@ -7,6 +7,8 @@
 
 namespace Exiled.Events.Patches.Generic
 {
+    using Exiled.API.Extensions;
+
 #pragma warning disable SA1402
     using System;
     using System.Collections.Generic;
@@ -96,8 +98,7 @@ public static bool CheckFriendlyFirePlayerRules(Footprint attackerFootprint, Ref
                 return true;
 
             // Only check friendlyFire if the FootPrint hasn't changed (Fix for Grenade not dealing damage because it's from a dead player)
-            // TODO rework FriendlyFireRule to make it compatible with Footprint
-            if (!attackerFootprint.Equals(new Footprint(attackerFootprint.Hub)))
+            if (!attackerFootprint.CompareLife(new Footprint(attackerFootprint.Hub)))
                 return false;
 
             // Check if attackerFootprint.Hub or victimHub is null and log debug information