Skip to content

New Shooting patch#249

Merged
VALERA771 merged 9 commits intoExMod-Team:scpsl14from
Banalny-Banan:scpsl14
Dec 7, 2024
Merged

New Shooting patch#249
VALERA771 merged 9 commits intoExMod-Team:scpsl14from
Banalny-Banan:scpsl14

Conversation

@Banalny-Banan
Copy link
Copy Markdown

No description provided.

@Banalny-Banan
Copy link
Copy Markdown
Author

Not tested yet

@Banalny-Banan
Copy link
Copy Markdown
Author

Noooooo not the build errors forcing me to re-enable analyzers😭

Copy link
Copy Markdown

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts. Everything else seems fine. I hope that you've tested it

@VALERA771
Copy link
Copy Markdown

Also in future use pr template

@github-actions github-actions bot added API base-game-bug Bug from the main game labels Dec 1, 2024
@Banalny-Banan
Copy link
Copy Markdown
Author

I made it even worse by trying to rebase it on current scpsl14...

…an/scpsl14

# Conflicts:
#	EXILED/Exiled.Events/Patches/Events/Player/Shooting.cs
@Banalny-Banan
Copy link
Copy Markdown
Author

Still needs testing btw

@VALERA771 VALERA771 added the Requires Testing Things need to be verified by an Exiled Developer/Contributor label Dec 1, 2024
@Banalny-Banan Banalny-Banan marked this pull request as draft December 1, 2024 17:08
@Banalny-Banan Banalny-Banan marked this pull request as ready for review December 1, 2024 17:25
@Banalny-Banan
Copy link
Copy Markdown
Author

@VALERA771 I tested and fixed everything, should be ready to merge

@VALERA771
Copy link
Copy Markdown

Some docs like claim's target position remark should be added as remarks

@IRacle1
Copy link
Copy Markdown
Member

IRacle1 commented Dec 1, 2024

Other things and patch itself ill check again tmrw😊

@Misaka-ZeroTwo Misaka-ZeroTwo linked an issue Dec 2, 2024 that may be closed by this pull request
@VALERA771 VALERA771 removed the Requires Testing Things need to be verified by an Exiled Developer/Contributor label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base-game-bug Bug from the main game Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shooting/Shot events are not called

3 participants