Skip to content

yipee#244

Merged
louis1706 merged 19 commits intoExMod-Team:scpsl14from
IRacle1:sigmaTemp
Nov 28, 2024
Merged

yipee#244
louis1706 merged 19 commits intoExMod-Team:scpsl14from
IRacle1:sigmaTemp

Conversation

@IRacle1
Copy link
Copy Markdown
Member

@IRacle1 IRacle1 commented Nov 27, 2024

Description

Describe the changes
Fixed patches as i understand their logic, prob not the best solutions
now thinking about firearm stuff

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@IRacle1 IRacle1 self-assigned this Nov 27, 2024
@github-actions github-actions bot added Transpiler API base-game-bug Bug from the main game labels Nov 27, 2024
@SrLicht
Copy link
Copy Markdown

SrLicht commented Nov 28, 2024

SpawningEventArg got fixed in #245

@IRacle1
Copy link
Copy Markdown
Member Author

IRacle1 commented Nov 28, 2024

SpawningEventArg got fixed in #245

yeah, but in your code there is no event calling for non-fpc roles, I dont like it in terms of features, but I guess your option is even more logical (I'm still doing other internal fixes to the role system, so dont really care what I've got in here, yet)

@louis1706 louis1706 merged commit 2bfdb52 into ExMod-Team:scpsl14 Nov 28, 2024
This was referenced Nov 28, 2024
@Misaka-ZeroTwo Misaka-ZeroTwo mentioned this pull request Nov 28, 2024
8 tasks
Misaka-ZeroTwo added a commit that referenced this pull request Nov 28, 2024
#244 and #253
---------

Co-authored-by: Misaka-ZeroTwo <45165615+Misaka-ZeroTwo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants