Conversation
Mikihero
left a comment
Mikihero
left a comment
There was a problem hiding this comment.
might also wanna fix all the shit stylecops asking about
|
i honestly don't know, how to do it because most of the stuff is impossible to do it being something on the game not possible to cache |
VALERA771
left a comment
VALERA771
left a comment
There was a problem hiding this comment.
We have had internal discussions about npcs in Player.List and came to decision that list shouldn't contain them. Can you do a separate list for npc in its class and remove them from list in player's class?
I wanted to ask that but figure it out on just doing the fixes and nothing else and yes i will do a dictionary that is not included |
VALERA771
left a comment
VALERA771
left a comment
There was a problem hiding this comment.
We still can use same player's class dictionary but just remove npc from List in player's class
Like what i showed and merged on the pr? |
|
OH I understand |
VALERA771
left a comment
VALERA771
left a comment
There was a problem hiding this comment.
Make it IReadonlyCollection and it'll be perfect
Done. |
6 participants
Description
Describe the changes
Changes the entire NPC Api to use the dummies and adds the new follow system for dummies
What is the current behavior? (You can also link to an open issue here)
None
What is the new behavior? (if this is a feature change)
None
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes some method in specific Spawn() Used to have the InstanceId but now removed.
Other information:
Introduces a new way and actually vsr friendly to the npcs, removing the old system without alot of changes
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other