Skip to content

CustomItems and CustomRoles fix #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
louis1706 merged 1 commit into from
Nov 27, 2024
Merged

CustomItems and CustomRoles fix #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion EXILED/Exiled.CustomItems/API/Features/CustomItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1011,7 +1011,7 @@ protected virtual void ShowSelectedMessage(Player player)

private void OnInternalOwnerChangingRole(ChangingRoleEventArgs ev)
{
if (ev.Reason == SpawnReason.Escaped)
if (ev.Reason is SpawnReason.Escaped or SpawnReason.Destroyed)
return;

foreach (Item item in ev.Player.Items.ToList())
Expand Down
3 changes: 3 additions & 0 deletions EXILED/Exiled.CustomRoles/API/Features/CustomRole.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,6 +926,9 @@ private void OnInternalSpawning(SpawningEventArgs ev)

private void OnInternalChangingRole(ChangingRoleEventArgs ev)
{
if(ev.Reason == SpawnReason.Destroyed)
return;

if (Check(ev.Player) && ((ev.NewRole == RoleTypeId.Spectator && !KeepRoleOnDeath) || (ev.NewRole != RoleTypeId.Spectator && ev.NewRole != Role && !KeepRoleOnChangingRole)))
{
RemoveRole(ev.Player);
Expand Down