Skip to content

Hcz bulk door fix#207

Merged
louis1706 merged 2 commits intoExMod-Team:scpsl14from
Undid-Iridium:HczBulkDoor-Fix
Nov 27, 2024
Merged

Hcz bulk door fix#207
louis1706 merged 2 commits intoExMod-Team:scpsl14from
Undid-Iridium:HczBulkDoor-Fix

Conversation

@Undid-Iridium
Copy link
Copy Markdown

#198

Breaking change, probably

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

image

@SticksDeveloper
Copy link
Copy Markdown

Hey, I noticed something in your code. I made a PR for the HCZ Containment Bulkhead Door aswell, but I like where you are going. Here's how to make yours a slight bit better.
string doorName = GameObject.name.GetBefore(' ') == "HCZ"? GameObject.name.GetBefore('(') : GameObject.name.GetBefore(' '); use this instead of just the if statement; it'll make it cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants