feat: [Exiled::API] StopDancing and StartDancing for SCP-3114 Role#189
Merged
VALERA771 merged 7 commits intoExMod-Team:devfrom Dec 30, 2024
Merged
feat: [Exiled::API] StopDancing and StartDancing for SCP-3114 Role#189VALERA771 merged 7 commits intoExMod-Team:devfrom
[Exiled::API] StopDancing and StartDancing for SCP-3114 Role#189VALERA771 merged 7 commits intoExMod-Team:devfrom
Conversation
Author
|
Don't know if i need to add IsDancing and other stuff to this let me know |
Author
|
And another issue while i was testing who made DanceType didn't match them with their byte |
|
Here should be just comment, not approval |
Author
|
Ok so i did an error in the code that made everything strange, im now using an internal value that is inside the class but actually never used |
Author
|
And found out that if the player has a skin can dance but only for the player who is SCP-3114 the other don't see him dance |
VALERA771
approved these changes
Nov 23, 2024
|
Also in future pls use for loop with |
Author
I can change it no problem with that |
[Exiled::API] StopDancing and StartDancing for SCP-3114 Role[Exiled::API] StopDancing and StartDancing for SCP-3114 Role
obvEve
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Adding the ability for Dancing with API
What is the current behavior? (You can also link to an open issue here)
The game by itself doesn't allow but there's left code from the client never used and so i took the variable and used it for the same reason
What is the new behavior? (if this is a feature change)
Ability to Dance
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other