Skip to content

Updated CustomItems & CustomRoles give commands to use default RAUtils.ProcessPlayerIdOrNamesList#179

Merged
VALERA771 merged 9 commits intoExMod-Team:devfrom
icedchai:master
Nov 25, 2024
Merged

Updated CustomItems & CustomRoles give commands to use default RAUtils.ProcessPlayerIdOrNamesList#179
VALERA771 merged 9 commits intoExMod-Team:devfrom
icedchai:master

Conversation

@icedchai
Copy link
Copy Markdown

Description

Describe the changes

What is the current behavior? (You can also link to an open issue here)
Commands currently evaluate only *, all, or Player.Id

What is the new behavior? (if this is a feature change)
Commands now evaluate players based on RAUtils.ProcessPlayerIdOrNamesList (eg @player.17.15) as well as *, all, or Player.Id.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking changes

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@louis1706
Copy link
Copy Markdown

Also build your branch with Release not Debug because you wouldn't seen all the error to fix issue of compiling

@icedchai
Copy link
Copy Markdown
Author

Alright. I'll do that as soon as I can.

Copy link
Copy Markdown

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some foreach loops can be simplified with LINQ extensions and PR must target dev branch

@icedchai icedchai changed the base branch from master to dev November 16, 2024 02:47
@github-actions github-actions bot removed the Events label Nov 18, 2024
Copy link
Copy Markdown

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

using Exiled.Permissions.Extensions;

using RemoteAdmin;
using UnityStandardAssets.Effects;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants