Add IsScp to RoleExtensions#176
Closed
LumiFae wants to merge 1 commit intoExMod-Team:masterfrom
LumiFae:master
Closed
Add IsScp to RoleExtensions#176LumiFae wants to merge 1 commit intoExMod-Team:masterfrom LumiFae:master
LumiFae wants to merge 1 commit intoExMod-Team:masterfrom
LumiFae:master
Conversation
Author
|
@VALERA771 moved to #177 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add IsScp to Role Extensions to easily check if the Role is an SCP role, I noticed there was .IsHuman and .IsAlive, but no .IsScp which could be useful to some people
What is the current behavior? (You can also link to an open issue here)
You either have to do !RoleTypeId.IsHuman && RoleTypeId.IsAlive or RoleTypeId.Team == Team.SCPs to check if the team is SCPs
What is the new behavior? (if this is a feature change)
You can now check with RoleTypeId.IsScp to see if the team is an SCP team or not.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, nobody will need to change anything if they don't want to.
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other