Skip to content

Add IsScp to RoleExtensions#176

Closed
LumiFae wants to merge 1 commit intoExMod-Team:masterfrom
LumiFae:master
Closed

Add IsScp to RoleExtensions#176
LumiFae wants to merge 1 commit intoExMod-Team:masterfrom
LumiFae:master

Conversation

@LumiFae
Copy link
Copy Markdown

@LumiFae LumiFae commented Nov 12, 2024

Description

Add IsScp to Role Extensions to easily check if the Role is an SCP role, I noticed there was .IsHuman and .IsAlive, but no .IsScp which could be useful to some people

What is the current behavior? (You can also link to an open issue here)

You either have to do !RoleTypeId.IsHuman && RoleTypeId.IsAlive or RoleTypeId.Team == Team.SCPs to check if the team is SCPs

What is the new behavior? (if this is a feature change)

You can now check with RoleTypeId.IsScp to see if the team is an SCP team or not.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No, nobody will need to change anything if they don't want to.

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

Copy link
Copy Markdown

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR must target dev branch

@LumiFae LumiFae closed this Nov 13, 2024
@LumiFae
Copy link
Copy Markdown
Author

LumiFae commented Nov 13, 2024

@VALERA771 moved to #177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants