Merged
Conversation
…me DoorLockType Signed-off-by: Mikhail Reznichenko <justmarfix@vk.com>
vladflotsky
previously requested changes
Nov 10, 2024
vladflotsky
left a comment
vladflotsky
left a comment
There was a problem hiding this comment.
PRs should target the dev branch, not master
|
https://discord.com/channels/656673194693885975/656674085425643534/1305208899288436779 tl;dr |
…new code Signed-off-by: Mikhail Reznichenko <justmarfix@vk.com>
louis1706
approved these changes
Nov 11, 2024
|
Will your fix display active locks correctly? |
DoorEvents.TriggerAction that what it does |
|
i have an suggestion can you add Lock method without the time argument |
Signed-off-by: Mikhail Reznichenko <justmarfix@vk.com>
JustMarfix
changed the title
Author
done |
louis1706
approved these changes
Nov 12, 2024
VALERA771
approved these changes
Nov 18, 2024
obvEve
approved these changes
Nov 18, 2024
louis1706
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improved Door.Lock method
What is the current behavior? (You can also link to an open issue here)
The Door.Lock method unlocks the door when the same DoorLockType has been used multiple times due to the code in Door.ChangeLock. It doesn't match the method name, so I fixed it.
What is the new behavior? (if this is a feature change)
Now, the Door.Lock method doesn't call the ChangeLock, but adds lock flags inside itself.
UPD: also, now there is one more Door.Lock method, that has no time argument
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other