Skip to content

Fix InteractingScp330EventArgs::Candy#124

Merged
louis1706 merged 1 commit intoExMod-Team:devfrom
VALERA771:rewrite-330
Oct 24, 2024
Merged

Fix InteractingScp330EventArgs::Candy#124
louis1706 merged 1 commit intoExMod-Team:devfrom
VALERA771:rewrite-330

Conversation

@VALERA771
Copy link
Copy Markdown

@VALERA771 VALERA771 commented Oct 4, 2024

Description

Describe the changes
Fixing InteractingScp330EventArgs::Candy

What is the current behavior? (You can also link to an open issue here)
Candy is incorrect
#118

What is the new behavior? (if this is a feature change)
Candy is correct

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@VALERA771 VALERA771 changed the title fix Fix InteractingScp330EventArgs::Candy Oct 4, 2024
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Micro styling fix. Otherwise, looks good.

@louis1706 louis1706 linked an issue Oct 20, 2024 that may be closed by this pull request
@louis1706 louis1706 merged commit 93dd6d8 into ExMod-Team:dev Oct 24, 2024
@Misaka-ZeroTwo Misaka-ZeroTwo mentioned this pull request Oct 24, 2024
Merged
@VALERA771 VALERA771 deleted the rewrite-330 branch December 20, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] InteractingScp330 return the wrong CandyKindID

2 participants