-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some comments in codegen #41
Conversation
Github action supports more concurrent jobs than travis CI
@@ -50,12 +50,15 @@ function augment_impl(var_offset::Int, op_offset::Int, head::DataType, tail::NTu | |||
num_affine, after_affine = uses_affinemap(head, tail) ? seek_connected(uses_affinemap, 0, head, tail) : (0, nothing) | |||
num_special, _ = seek_connected(x->(supports_permute(x)||supports_view(x)||supports_stepview(x)), 0, head, tail) | |||
num_lazy, after_lazy = seek_connected(supports_lazy, 0, head, tail) | |||
@assert num_special <= num_affine <= num_lazy # issue #40 | |||
if num_special >= num_affine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A subtlety here:
if num_special >= num_affine | |
if num_special > num_affine |
Here's the reasoning behind: when num_special == num_affine
, according to #40, all special operations support affinemap, hence they can be unrolled using unroll_applyaffine
Tests and benchmarks are required to verify this change. If luckily we can get a performance boost here. At present, I can't make any promise.
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Augmentor.jl/Augmentor.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/Augmentor.jl/Augmentor.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/Augmentor.jl/Augmentor.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
merge after #32