-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(CI): updated WizardTest to handle new email-validator error message #480
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
- Coverage 74.30% 73.59% -0.71%
==========================================
Files 45 45
Lines 2837 2886 +49
Branches 435 447 +12
==========================================
+ Hits 2108 2124 +16
- Misses 642 675 +33
Partials 87 87 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thanks @SamuelLarkin !
@@ -35,6 +35,9 @@ jobs: | |||
pip install cython | |||
pip install -e . | |||
pip install coverage | |||
- name: Log complete list of packages | |||
run: | | |||
pip freeze |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While debugging this, I've noticed that not all dependencies are listed in Install dependencies and package
. pip freeze
list them all in a nicer and more concise manner.
@@ -227,7 +227,11 @@ def test_bad_contact_email_step(self): | |||
self.assertTrue(step.validate("[email protected]")) | |||
self.assertFalse(step.validate("")) | |||
output = stdout.getvalue() | |||
self.assertIn("It must have exactly one @-sign", output) | |||
# Supporting email-validator prior and post 2.2.0 where the error string changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
57dbcab
to
a2b0a15
Compare
PR Goal?
email-validator
has a new version and it changed one of its error message which we test inWizardTest
.Update the
everyvoice.tests.test_wizard.WizardTest
to handle both error messages.Fixes?
Feedback sought?
Approval for merging.
Priority?
high
Tests added?
None
How to test?
Confidence?
High
Version change?
No but people will need to update their environment using
Related PRs?
@joanise pointed out the possibility of a dependency having been updated causing the error in the first place.