Fix(CI): updated WizardTest to handle new email-validator error message #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelLarkin
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
- Coverage 74.30% 73.59% -0.71%
==========================================
Files 45 45
Lines 2837 2886 +49
Branches 435 447 +12
==========================================
+ Hits 2108 2124 +16
- Misses 642 675 +33
Partials 87 87 ☔ View full report in Codecov by Sentry. |
SamuelLarkin
changed the title
roedoejet
approved these changes
Jun 20, 2024
| @@ -35,6 +35,9 @@ jobs: | |||
| pip install cython | |||
| pip install -e . | |||
| pip install coverage | |||
| - name: Log complete list of packages | |||
| run: | | |||
| pip freeze | |||
There was a problem hiding this comment.
While debugging this, I've noticed that not all dependencies are listed in Install dependencies and package. pip freeze list them all in a nicer and more concise manner.
| @@ -227,7 +227,11 @@ def test_bad_contact_email_step(self): | |||
| self.assertTrue(step.validate("[email protected]")) | |||
| self.assertFalse(step.validate("")) | |||
| output = stdout.getvalue() | |||
| self.assertIn("It must have exactly one @-sign", output) | |||
| # Supporting email-validator prior and post 2.2.0 where the error string changed. | |||
SamuelLarkin
force-pushed
the
dev.sl/email-validator
branch
from
57dbcab
to
a2b0a15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
email-validatorhas a new version and it changed one of its error message which we test inWizardTest.Update the
everyvoice.tests.test_wizard.WizardTestto handle both error messages.Fixes?
Feedback sought?
Approval for merging.
Priority?
high
Tests added?
None
How to test?
Confidence?
High
Version change?
No but people will need to update their environment using
Related PRs?
@joanise pointed out the possibility of a dependency having been updated causing the error in the first place.