-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes vocoder step bug in demo #458
Conversation
The author of this PR, wiitt, is not an activated member of this organization on Codecov. |
|
also remove unused import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix @wiitt ! Nice job on figuring out how the code works and fixing a real bug in the code 👏 👏
I noticed that it looks like you don't have our commit hooks installed, which will auto-format the code and validate your commit messages. Have a look at the contributing documentation for a guide on how to get set up. Once you've read it through let me know if it makes sense. I'll be happy to merge this. Thanks again @wiitt !
@@ -47,6 +44,7 @@ def synthesize_audio( | |||
devices="1", | |||
device=device, | |||
global_step=1, | |||
vocoder_global_step=1, # dummy value since the vocoder step is not used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice find, thanks for the comment explaining it as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @wiitt
PR Goal?
This PR provides a dummy value for vocoder_global_step which is not used in demo but is required for synthesize_helper and PredictionWritingWavCallback.
Fixes?
Fixes 453.
Feedback sought?
Check if this value is local to this file and does not affecting others.
Priority?
The bug blocks further work on the issue 448.
Tests added?
No additional testing was added.
How to test?
Run everyvoice demo.
Confidence?
Changes ready to merge.
Version change?
Bug fix.
Related PRs?
There are no other related PR.