Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes vocoder step bug in demo #458

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Fixes vocoder step bug in demo #458

merged 3 commits into from
Jun 11, 2024

Conversation

wiitt
Copy link
Collaborator

@wiitt wiitt commented Jun 10, 2024

PR Goal?

This PR provides a dummy value for vocoder_global_step which is not used in demo but is required for synthesize_helper and PredictionWritingWavCallback.

Fixes?

Fixes 453.

Feedback sought?

Check if this value is local to this file and does not affecting others.

Priority?

The bug blocks further work on the issue 448.

Tests added?

No additional testing was added.

How to test?

Run everyvoice demo.

Confidence?

Changes ready to merge.

Version change?

Bug fix.

Related PRs?

There are no other related PR.

@wiitt wiitt requested a review from roedoejet June 10, 2024 20:19
Copy link

codecov bot commented Jun 10, 2024

The author of this PR, wiitt, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

Copy link
Contributor

github-actions bot commented Jun 10, 2024

CLI load time: 0:00.23
Pull Request HEAD: 9af5f8d4d422ff53e68b39848c45848606ab9cbb
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

@wiitt wiitt linked an issue Jun 10, 2024 that may be closed by this pull request
also remove unused import
Copy link
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @wiitt ! Nice job on figuring out how the code works and fixing a real bug in the code 👏 👏

I noticed that it looks like you don't have our commit hooks installed, which will auto-format the code and validate your commit messages. Have a look at the contributing documentation for a guide on how to get set up. Once you've read it through let me know if it makes sense. I'll be happy to merge this. Thanks again @wiitt !

@@ -47,6 +44,7 @@ def synthesize_audio(
devices="1",
device=device,
global_step=1,
vocoder_global_step=1, # dummy value since the vocoder step is not used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find, thanks for the comment explaining it as well!

@roedoejet roedoejet self-requested a review June 11, 2024 16:37
Copy link
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @wiitt

@roedoejet roedoejet merged commit e044cd5 into main Jun 11, 2024
3 of 4 checks passed
@roedoejet roedoejet deleted the dev.vg/453-set-any-vostep branch June 11, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo issue
2 participants