Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Praat TextGrid as possible synthesis output #436

Merged
merged 2 commits into from
May 27, 2024

Conversation

roedoejet
Copy link
Member

@roedoejet roedoejet commented May 25, 2024

PR Goal?

Add the option to synthesize Praat TextGrids using the predicted durations. This lays the foundation for adding a .readalong callback (@joanise 😉 )

As an example (produced with this PR):

image

Fixes?

#435

Feedback sought?

Try it out! Sanity check

Priority?

Medium

Tests added?

Still need to do this...

How to test?

add the -O textgrid to the synthesize command (instead of spec or wav as previously)

Confidence?

high - I've been testing this out

Version change?

N/A

Related PRs?

EveryVoiceTTS/FastSpeech2_lightning#80

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.89%. Comparing base (c4c7e52) to head (e40d84b).

Files Patch % Lines
everyvoice/text/text_processor.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   73.94%   73.89%   -0.06%     
==========================================
  Files          43       43              
  Lines        2618     2620       +2     
  Branches      404      405       +1     
==========================================
  Hits         1936     1936              
- Misses        602      603       +1     
- Partials       80       81       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roedoejet roedoejet changed the title Dev.ap/textgrid output Add Praat TextGrid as possible synthesis output May 25, 2024
Copy link
Contributor

github-actions bot commented May 25, 2024

CLI load time: 0:00.23
Pull Request HEAD: de413a792f9f88b45cab6c901a71253e6b53db54
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

@joanise
Copy link
Member

joanise commented May 27, 2024

Do we have any unit testing covering this? Based on the line that's not covered in this PR, I'm guessing there is not. It would be really important to add at least minimal testing.

Copy link
Member

@joanise joanise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good except we need to exercise this code in CI.

Copy link
Collaborator

@SamuelLarkin SamuelLarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marctessier
Copy link
Collaborator

marctessier commented May 27, 2024

I played with it a little bit. It generated a text-grid file. I was able to open it using PRAAT.

side node: I did not look at all the finer details of the text-grid file yet... but good to go for a first release!

@roedoejet
Copy link
Member Author

Thanks all! You're right @joanise - I've made an issue

@roedoejet roedoejet merged commit de413a7 into main May 27, 2024
2 checks passed
@roedoejet roedoejet deleted the dev.ap/textgrid-output branch May 27, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants