Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old HiFiGAN code #426

Merged
merged 2 commits into from
May 15, 2024
Merged

Remove old HiFiGAN code #426

merged 2 commits into from
May 15, 2024

Conversation

roedoejet
Copy link
Member

@roedoejet roedoejet commented May 13, 2024

PR Goal?

Removes stale hifigan code

Fixes?

#415

Feedback sought?

Sanity check

Priority?

medium

Tests added?

Just removed a test

How to test?

Just scan for errors

Confidence?

High. I've tested this works with the CLI

Version change?

N/A (pre-alpha)

Related PRs

EveryVoiceTTS/FastSpeech2_lightning#74

Copy link
Contributor

CLI load time: 0:00.29
Pull Request HEAD: 5cde4145a896d4a9973ad6dd9deb41428ac230fd
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.02%. Comparing base (110512c) to head (5cde414).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   73.49%   76.02%   +2.53%     
==========================================
  Files          43       42       -1     
  Lines        2852     2757      -95     
  Branches      468      455      -13     
==========================================
  Hits         2096     2096              
+ Misses        671      576      -95     
  Partials       85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roedoejet roedoejet changed the title Dev.ap/remove hfg Remove old HiFiGAN code May 14, 2024
Copy link
Member

@joanise joanise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@roedoejet roedoejet merged commit 5cde414 into main May 15, 2024
4 checks passed
@roedoejet roedoejet deleted the dev.ap/remove-hfg branch May 15, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants