Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: recommendations for doing multi-repo PRs #410

Merged
merged 3 commits into from
May 1, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Apr 30, 2024

PR Goal?

Provide recommendations to contributors on how to handle multi-repo PRs.

Fixes?

Fixes #406

Feedback sought?

I think my text is much too verbose. So:

  • is this useful?
  • What can be made more concise?
  • What should just removed?

Priority?

normal

Confidence?

medium-low, see above

Version change?

no

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.45%. Comparing base (c80c8ef) to head (83536df).

❗ Current head 83536df differs from pull request most recent head ec17fa1. Consider uploading reports for the commit ec17fa1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage   73.45%   73.45%           
=======================================
  Files          43       43           
  Lines        2837     2837           
  Branches      467      467           
=======================================
  Hits         2084     2084           
  Misses        668      668           
  Partials       85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Apr 30, 2024

CLI load time: 0:00.30
Pull Request HEAD: ec17fa116bf8b840efd368c9bd051c18409a6ece
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

Copy link
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow - this is incredibly thorough. Great content @joanise ! One minor typo, otherwise it looks good to me and will be a good starting point for new contributors.

Contributing.md Outdated Show resolved Hide resolved
@joanise joanise merged commit dd09b8a into main May 1, 2024
2 checks passed
@joanise joanise deleted the dev.ej/doc-multi-repo-prs branch May 1, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the multi-repo PR process
2 participants