-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: save processed audio in wav instead of pt #382
Conversation
9fc1d4e
to
8929b83
Compare
Hi, finally this PR is ready for review :) Look forward to your feedback! |
The author of this PR, MENGZHEGENG, is not an activated member of this organization on Codecov. |
|
9de27ce
to
03dca0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic - looks great to me @MENGZHEGENG . Just some very minor changes requested in the submodules. Everything else looks good. I tested preprocessing out on my machine and it worked great. I didn't try training yet.
Could you also update the e2e dataset loader to use .wav and not .pt? https://github.com/roedoejet/EveryVoice/blob/03dca0e270e6cf173c12f8b71bd4139a9aa8db88/everyvoice/model/e2e/dataset.py#L102
It looks good Tim. I di a few extra tests to compared training times using this and the latest version of EV. using 1000 entries of LJ .. Both took ~ 1h2minutes. So it looks like it does not impact the training performance. Save_wave 11:06 -> 12:08 |
Small detail: once your PRs are ready, you should rename them to remove the |
Thanks Eric for the reminder and I've removed the [WIP]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much Tim, this will be very helpful! great work
44118a8
to
1e1954c
Compare
53e01e1
to
9b8ecf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaned up into two commits, looks great, thanks!
Thank you so much Eric for your guidances and instructions on cleaning the commits! |
Solve #336
Now it saves the processed audio in wav instead of pt.
Related PR: