Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fail CI if everyvoice -h imports shared_types, that is slow #369

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Apr 4, 2024

Let's just be a bit more agressive blocking expensive imports: the easiest way to let expensive imports slip into everyvoice -h is by accidentally causing it to import everyvoice.config.shared_types, directly or indirectly. So let's explicitly look for the and reject a commit in CI if it causes this.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

CLI load time: 0:00.30
Pull Request HEAD: 5fd80ad40953ce03b0948b862d0ad1349fabf955
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      1014 |     110160 |   typer.main
import time:       354 |     125865 | typer

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.49%. Comparing base (f7f8570) to head (5fd80ad).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   71.49%   71.49%           
=======================================
  Files          39       39           
  Lines        2543     2543           
  Branches      390      390           
=======================================
  Hits         1818     1818           
  Misses        653      653           
  Partials       72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@SamuelLarkin SamuelLarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@joanise joanise merged commit 0a99b5d into main Apr 10, 2024
4 checks passed
@joanise joanise deleted the dev.ej/cli-no-shared_types branch April 10, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants