ci: fail CI if everyvoice -h imports shared_types, that is slow #369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's just be a bit more agressive blocking expensive imports: the easiest way to let expensive imports slip into
everyvoice -h
is by accidentally causing it to importeveryvoice.config.shared_types
, directly or indirectly. So let's explicitly look for the and reject a commit in CI if it causes this.