Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trimming white spaces in answers #344

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

SamuelLarkin
Copy link
Collaborator

@SamuelLarkin SamuelLarkin commented Mar 19, 2024

fixes: #324

New unittests:

python \
  -m unittest \
    everyvoice.tests.test_wizard.WizardTest.test_leading_white_space_in_wav_dir \
    everyvoice.tests.test_wizard.WizardTest.test_leading_white_space_in_filelist \
    everyvoice.tests.test_wizard.WizardTest.test_leading_white_space_in_outpath

@SamuelLarkin SamuelLarkin force-pushed the dev.sl/324_trimming_leading_white_spaces branch 2 times, most recently from 73993ae to fa5fe88 Compare March 19, 2024 21:27
@MENGZHEGENG
Copy link
Collaborator

Thanks Samuel! It looks good to me :)

@SamuelLarkin SamuelLarkin force-pushed the dev.sl/324_trimming_leading_white_spaces branch from fa5fe88 to 5a42c11 Compare March 20, 2024 21:02
Copy link
Contributor

CLI load time: 0:00.31
Pull Request HEAD: b498dc672f0ec6399c3b1d28279a7d6675f94821
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

@SamuelLarkin
Copy link
Collaborator Author

SamuelLarkin commented Mar 20, 2024

questionary is build on top of python-prompt-toolkit which has the following page on how to perfrom Unit testing as suggested by Documentation: add documentation on how to test an application using questionary in the issue
tmbo/questionary#355.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.46%. Comparing base (71652a4) to head (b498dc6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   71.23%   71.46%   +0.23%     
==========================================
  Files          39       39              
  Lines        2527     2541      +14     
  Branches      390      390              
==========================================
+ Hits         1800     1816      +16     
+ Misses        657      653       -4     
- Partials       70       72       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelLarkin SamuelLarkin changed the title [WIP]feat: trimming white spaces in answers feat: trimming white spaces in answers Mar 20, 2024
Copy link
Collaborator

@MENGZHEGENG MENGZHEGENG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks Sam!

@SamuelLarkin SamuelLarkin merged commit 2681f40 into main Mar 21, 2024
4 checks passed
@SamuelLarkin SamuelLarkin deleted the dev.sl/324_trimming_leading_white_spaces branch March 21, 2024 15:32
@MENGZHEGENG MENGZHEGENG restored the dev.sl/324_trimming_leading_white_spaces branch March 21, 2024 15:39
@MENGZHEGENG MENGZHEGENG deleted the dev.sl/324_trimming_leading_white_spaces branch March 21, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trimming the leading space of input file address
2 participants