ci: increase integration-test-build timeout from 30 to 45 minutes#6241
Merged
desmondcheongzx merged 1 commit intomainfrom Feb 19, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Greptile SummaryThis PR increases the timeout for the
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: e38fa34 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6241 +/- ##
==========================================
- Coverage 73.34% 73.31% -0.03%
==========================================
Files 999 999
Lines 132382 132373 -9
==========================================
- Hits 97089 97048 -41
- Misses 35293 35325 +32 🚀 New features to boost your workflow:
|
desmondcheongzx
added a commit
that referenced
this pull request
Feb 19, 2026
) The 45-minute timeout from #6241 is still not enough — the build timed out again in [this run](https://github.com/Eventual-Inc/Daft/actions/runs/22172157962/job/64112220739) because the Rust cache (`Swatinem/rust-cache`) missed entirely, forcing a cold build of all 676 crates. Bumping to 90 minutes so the cold build can complete and repopulate the cache. Longer term we should investigate `sccache` or larger runners to make cold builds more robust. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gavin9402
pushed a commit
to gavin9402/Daft
that referenced
this pull request
Apr 7, 2026
…entual-Inc#6241) PR Eventual-Inc#6177 (OpenDAL) added ~110 new crate entries to Cargo.lock, which invalidated the Rust compilation cache. The `integration-test-build` job needs ~29 minutes for a full rebuild, but the 30-minute timeout causes it to be cancelled before the post-job cache save runs. This creates a deadlock: every subsequent build also misses the cache and times out. Bumping to 45 minutes lets the first cache-miss build complete and save, after which subsequent builds should return to ~10 minutes. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gavin9402
pushed a commit
to gavin9402/Daft
that referenced
this pull request
Apr 7, 2026
…entual-Inc#6244) The 45-minute timeout from Eventual-Inc#6241 is still not enough — the build timed out again in [this run](https://github.com/Eventual-Inc/Daft/actions/runs/22172157962/job/64112220739) because the Rust cache (`Swatinem/rust-cache`) missed entirely, forcing a cold build of all 676 crates. Bumping to 90 minutes so the cold build can complete and repopulate the cache. Longer term we should investigate `sccache` or larger runners to make cold builds more robust. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #6177 (OpenDAL) added ~110 new crate entries to Cargo.lock, which invalidated the Rust compilation cache. The
integration-test-buildjob needs ~29 minutes for a full rebuild, but the 30-minute timeout causes it to be cancelled before the post-job cache save runs. This creates a deadlock: every subsequent build also misses the cache and times out.Bumping to 45 minutes lets the first cache-miss build complete and save, after which subsequent builds should return to ~10 minutes.