Skip to content

ci: increase integration-test-build timeout from 30 to 45 minutes#6241

Merged
desmondcheongzx merged 1 commit intomainfrom
desmond/ci/bump-integration-build-timeout
Feb 19, 2026
Merged

ci: increase integration-test-build timeout from 30 to 45 minutes#6241
desmondcheongzx merged 1 commit intomainfrom
desmond/ci/bump-integration-build-timeout

Conversation

@desmondcheongzx
Copy link
Copy Markdown
Collaborator

PR #6177 (OpenDAL) added ~110 new crate entries to Cargo.lock, which invalidated the Rust compilation cache. The integration-test-build job needs ~29 minutes for a full rebuild, but the 30-minute timeout causes it to be cancelled before the post-job cache save runs. This creates a deadlock: every subsequent build also misses the cache and times out.

Bumping to 45 minutes lets the first cache-miss build complete and save, after which subsequent builds should return to ~10 minutes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot added the ci label Feb 19, 2026
@desmondcheongzx desmondcheongzx enabled auto-merge (squash) February 19, 2026 06:27
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Feb 19, 2026

Greptile Summary

This PR increases the timeout for the integration-test-build job from 30 to 45 minutes. The change addresses a specific deadlock issue: PR #6177 added ~110 new Cargo.lock entries, invalidating the Rust compilation cache. The job requires ~29 minutes for a full rebuild, but the 30-minute timeout causes premature cancellation before the post-job cache save step, preventing cache population for subsequent builds.

  • Timeout increased from 30 to 45 minutes for integration-test-build job
  • Change is proportionate to the actual build time requirement (~29 minutes)
  • Other similar build jobs (test-imports-platform) remain at 30 minutes, which appears reasonable as they don't build in release mode

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a simple, well-justified timeout increase for a CI job. The timeout value (45 minutes) is proportionate to the actual measured build time (~29 minutes) and provides reasonable buffer. The change only affects CI infrastructure, not production code, and addresses a specific, documented cache invalidation issue.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/pr-test-suite.yml Increased integration-test-build job timeout from 30 to 45 minutes to accommodate cache-miss rebuilds after OpenDAL dependency additions

Last reviewed commit: e38fa34

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@desmondcheongzx desmondcheongzx merged commit d642a25 into main Feb 19, 2026
29 of 31 checks passed
@desmondcheongzx desmondcheongzx deleted the desmond/ci/bump-integration-build-timeout branch February 19, 2026 07:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.31%. Comparing base (e6d6964) to head (e38fa34).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6241      +/-   ##
==========================================
- Coverage   73.34%   73.31%   -0.03%     
==========================================
  Files         999      999              
  Lines      132382   132373       -9     
==========================================
- Hits        97089    97048      -41     
- Misses      35293    35325      +32     

see 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

desmondcheongzx added a commit that referenced this pull request Feb 19, 2026
)

The 45-minute timeout from #6241 is still not enough — the build timed
out again in [this
run](https://github.com/Eventual-Inc/Daft/actions/runs/22172157962/job/64112220739)
because the Rust cache (`Swatinem/rust-cache`) missed entirely, forcing
a cold build of all 676 crates. Bumping to 90 minutes so the cold build
can complete and repopulate the cache.

Longer term we should investigate `sccache` or larger runners to make
cold builds more robust.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gavin9402 pushed a commit to gavin9402/Daft that referenced this pull request Apr 7, 2026
…entual-Inc#6241)

PR Eventual-Inc#6177 (OpenDAL) added ~110 new crate entries to Cargo.lock, which
invalidated the Rust compilation cache. The `integration-test-build` job
needs ~29 minutes for a full rebuild, but the 30-minute timeout causes
it to be cancelled before the post-job cache save runs. This creates a
deadlock: every subsequent build also misses the cache and times out.

Bumping to 45 minutes lets the first cache-miss build complete and save,
after which subsequent builds should return to ~10 minutes.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gavin9402 pushed a commit to gavin9402/Daft that referenced this pull request Apr 7, 2026
…entual-Inc#6244)

The 45-minute timeout from Eventual-Inc#6241 is still not enough — the build timed
out again in [this
run](https://github.com/Eventual-Inc/Daft/actions/runs/22172157962/job/64112220739)
because the Rust cache (`Swatinem/rust-cache`) missed entirely, forcing
a cold build of all 676 crates. Bumping to 90 minutes so the cold build
can complete and repopulate the cache.

Longer term we should investigate `sccache` or larger runners to make
cold builds more robust.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant