Skip to content

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Sep 9, 2025

Changes Made

Seems like haskell + swap storage is enough, and seems like android is quite the offender.

Ran three times.

Related Issues

Checklist

  • Documented in API Docs (if applicable)
  • Documented in User Guide (if applicable)
  • If adding a new documentation page, doc is added to docs/mkdocs.yml navigation
  • Documentation builds and is formatted properly (tag @/ccmao1130 for docs review)

Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.22%. Comparing base (1c24e34) to head (4410853).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5178      +/-   ##
==========================================
- Coverage   74.29%   72.22%   -2.07%     
==========================================
  Files         959      959              
  Lines      123361   127188    +3827     
==========================================
+ Hits        91653    91865     +212     
- Misses      31708    35323    +3615     

see 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@colin-ho colin-ho changed the title wip: remove free disk space ci: Reduce free disk space time Sep 9, 2025
@github-actions github-actions bot added the ci label Sep 9, 2025
@colin-ho colin-ho requested a review from kevinzwang September 9, 2025 21:45
@colin-ho colin-ho marked this pull request as ready for review September 9, 2025 21:45
sudo apt-get install ffmpeg libsm6 libxext6 -y
# - run: |
# sudo apt-get update
# sudo apt-get install ffmpeg libsm6 libxext6 -y
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will delete this

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR optimizes the CI pipeline's disk space cleanup process by making the free-disk-space action more selective about which system components to remove. The change modifies the .github/workflows/pr-test-suite.yml file to configure the jlumbroso/free-disk-space action with specific parameters:

  • Only removes Haskell packages (haskell: true) and swap storage (swap-storage: true)
  • Preserves Android SDK, .NET, Docker images, tool cache, and large packages by setting them to false
  • Comments out the apt-get installation step for ffmpeg, libsm6, and libxext6 packages

The developer's experimentation revealed that removing Android components was particularly time-consuming ("android is quite the offender"), leading to this targeted approach. This change fits into Daft's CI infrastructure by maintaining the disk space cleanup functionality while reducing execution time. The PR represents an iterative optimization based on empirical testing - the developer mentions running the configuration twice successfully and testing a third time to validate the approach.

Confidence score: 3/5

  • This PR has moderate risk due to potential breaking changes from removing system package installations
  • Score reflects concerns about commented-out multimedia library installations that may be needed for certain tests or functionality
  • Pay close attention to any tests that depend on ffmpeg or multimedia processing capabilities

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@colin-ho colin-ho merged commit 60f447f into main Sep 10, 2025
40 of 41 checks passed
@colin-ho colin-ho deleted the colin/try-remove-free-disk-space branch September 10, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants