-
Notifications
You must be signed in to change notification settings - Fork 296
ci: Reduce free disk space time #5178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5178 +/- ##
==========================================
- Coverage 74.29% 72.22% -2.07%
==========================================
Files 959 959
Lines 123361 127188 +3827
==========================================
+ Hits 91653 91865 +212
- Misses 31708 35323 +3615 🚀 New features to boost your workflow:
|
.github/workflows/pr-test-suite.yml
Outdated
sudo apt-get install ffmpeg libsm6 libxext6 -y | ||
# - run: | | ||
# sudo apt-get update | ||
# sudo apt-get install ffmpeg libsm6 libxext6 -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will delete this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR optimizes the CI pipeline's disk space cleanup process by making the free-disk-space action more selective about which system components to remove. The change modifies the .github/workflows/pr-test-suite.yml
file to configure the jlumbroso/free-disk-space
action with specific parameters:
- Only removes Haskell packages (
haskell: true
) and swap storage (swap-storage: true
) - Preserves Android SDK, .NET, Docker images, tool cache, and large packages by setting them to
false
- Comments out the
apt-get
installation step forffmpeg
,libsm6
, andlibxext6
packages
The developer's experimentation revealed that removing Android components was particularly time-consuming ("android is quite the offender"), leading to this targeted approach. This change fits into Daft's CI infrastructure by maintaining the disk space cleanup functionality while reducing execution time. The PR represents an iterative optimization based on empirical testing - the developer mentions running the configuration twice successfully and testing a third time to validate the approach.
Confidence score: 3/5
- This PR has moderate risk due to potential breaking changes from removing system package installations
- Score reflects concerns about commented-out multimedia library installations that may be needed for certain tests or functionality
- Pay close attention to any tests that depend on ffmpeg or multimedia processing capabilities
1 file reviewed, no comments
Changes Made
Seems like haskell + swap storage is enough, and seems like android is quite the offender.
Ran three times.
Related Issues
Checklist
docs/mkdocs.yml
navigation